Skip to content

Localize the ordinal long date - #105864

Merged
roryabraham merged 7 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-ordinal-date
Nov 9, 2026
Merged

roryabraham merged 7 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-ordinal-date

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT was the hand-written date-fns pattern MMMM do, yyyy. The pattern fixes the US component order, so other languages showed their own month name in an English shape, for example Juni 20., 2026 in German.

It now uses date-fns' localized long date token PPP. In English PPP already includes the ordinal day, so English output does not change:

Language Before After
English June 20th, 2026 June 20th, 2026 (unchanged)
German Juni 20., 2026 20. Juni 2026
Spanish junio 20º, 2026 20 de junio de 2026
Japanese 6月 20日, 2026 2026年6月20日

This constant is used in two places: the auto-renewal date on the workspace plan type page, and the violation snapshot start date in the empty Search view.

This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order.

Update: renewal day-shift fix

This PR now also fixes the annual renewal date on the workspace plan type page. privateSubscription.endDate is a yyyy-MM-dd value, and passing the string straight to format read it as UTC midnight, so the page showed the previous day in timezones behind UTC. It is now parsed with parseISO, which reads it as a local calendar day. This fix comes from #105846. I verified it by running tests/ui/WorkspacePlanRenewalDateTest.tsx with TZ=America/Los_Angeles: it fails without the fix and passes with it. CI runs in UTC, so the test there only checks the German order.

Update: violation snapshot day-shift fix

This PR now also includes the fix from #105872, which is closed in favor of this PR since both change how MONTH_DAY_YEAR_ORDINAL_FORMAT dates are shown. formatViolationSnapshotStartedAtDate read a date-only snapshot (yyyy-MM-dd) as the device's local midnight and then moved that instant into the user's timezone, so a user whose timezone is behind the device's saw the previous day. A date-only value is a calendar day, so it is now formatted as is; datetime values are still shown in the user's timezone. The new DateUtilsTest case for America/New_York fails without the fix in CI's UTC runner.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. Open Settings > Preferences > Language and select Deutsch.
  2. Open a workspace on an annual subscription and go to Overview > Plan type.
  3. Verify the auto-renewal date reads in German order, for example 20. Juni 2026.
  4. Switch the language back to English and verify the date reads June 20th, 2026, the same as before.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. Formatting is local and does not depend on the network.

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-11-05.at.12.13.01.PM.mov

Switch CONST.DATE.MONTH_DAY_YEAR_ORDINAL_FORMAT to date-fns' localized PPP
token so other languages use their own component order. English output is
unchanged because en-US's PPP already carries the ordinal day.
Parse the subscription end date with parseISO so the yyyy-MM-dd value is read
as a local calendar day instead of UTC midnight, which showed the previous day
in timezones behind UTC. Add the renewal date test from Expensify#105846.
@shubham1206agra
shubham1206agra marked this pull request as ready for review November 5, 2026 06:44
@shubham1206agra
shubham1206agra requested review from a team as code owners November 5, 2026 06:44
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and removed request for a team November 5, 2026 06:45
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team November 5, 2026 06:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T07:03:23.480203Z 70121a7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@linhvovan29546

linhvovan29546 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Image Image
iOS: mWeb Safari
MacOS: Chrome / Safari Image Image

A date-only snapshot start is a calendar boundary, so format it directly
instead of converting device-local midnight into the user's timezone, which
showed the previous day for timezones behind the device's. UTC datetimes still
convert into the user's timezone.
garrettmknight
garrettmknight previously approved these changes Nov 6, 2026

@garrettmknight garrettmknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective.

@roryabraham

Copy link
Copy Markdown
Contributor

@shubham1206agra conflicts

@shubham1206agra

Copy link
Copy Markdown
Contributor Author

@roryabraham Resolved

@roryabraham
roryabraham merged commit 520e267 into Expensify:main Nov 9, 2026
36 of 37 checks passed
@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Nov 9, 2026
72 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only fixes date localization and timezone-related day shifts in existing renewal and violation snapshot displays, without adding new screens, interactions, or user data.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes date localization and incorrect day shifts in existing displays, restoring expected behavior without adding a workflow or making existing article text incorrect.


view run

@IuliiaHerets

Copy link
Copy Markdown

Hi @shubham1206agra. QA team doesn't see any auto-renewal date displayed under Workspaces > Overview > Plan type. Is there a specific account QA should use for this test, or could you please advise how to proceed?

cc @roryabraham @garrettmknight @linhvovan29546

bandicam.2026-11-10.11-39-35-234.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants