Skip to content

Format the e-receipt date with the shared long-date helper - #105870

Merged
roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-receipts
Nov 10, 2026
Merged

roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-receipts

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The e-receipt built its date by passing the hand-written pattern CONST.DATE.MONTH_DAY_YEAR_FORMAT (MMMM d, yyyy) into getTransactionDetails. That ties the receipt to a fixed US-order pattern that cannot be localized.

The e-receipt now reads the plain yyyy-MM-dd date from getTransactionDetails and formats it with DateUtils.formatToReadableString, the shared long-date helper. The output is unchanged today (June 20, 2026), and the receipt picks up the localized long date (for example 20. Juni 2026 in German) from the companion PR that localizes formatToReadableString. The calendar day is still the stored day, with no shift in timezones behind UTC.

PerDiemEReceipt passed the same pattern to getTransactionDetails but never used the formatted date, so the unused argument is removed.

With those two gone, nothing passes a date format or a locale to getTransactionDetails any more, so both parameters are removed:

  • getTransactionDetails drops createdDateFormat and dateFnsLocale. created is always yyyy-MM-dd, which date-fns writes the same way in every locale (checked against all 95 date-fns locales), so a date shown to the user is formatted from it with the user's locale.
  • getFormattedCreated takes only the transaction and uses DateUtils.formatMachineDateWithUTCTimeZone, since every caller already used the default yyyy-MM-dd.
  • The 10 calls that passed undefined only to reach a later parameter (policy, allowNegativeAmount, disableOppositeConversion or reportOwnerAsAttendee) drop that argument. The other arguments keep their meaning.

This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. Open an Expensify Card expense that shows an e-receipt.
  2. Verify the e-receipt's transaction date reads as a long date, for example June 20, 2026, on the same day as the expense.
  3. Open an expense and change its date. Verify the new date is shown and saved.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshot 2026-11-07 at 7 11 56 PM

Read the plain yyyy-MM-dd date from getTransactionDetails and format it with
DateUtils.formatToReadableString instead of passing the hand-written
MONTH_DAY_YEAR_FORMAT pattern through getTransactionDetails. Output is
unchanged today and follows the shared helper once it is localized. Drop the
unused format argument from PerDiemEReceipt.
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/EReceipt.tsx 96.29% <100.00%> (+93.79%) ⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx 78.67% <100.00%> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx 88.67% <100.00%> (ø)
src/libs/DateUtils.ts 90.17% <ø> (ø)
src/libs/MergeTransactionUtils.ts 91.48% <100.00%> (ø)
src/libs/ReportUtils.ts 90.42% <ø> (-0.03%) ⬇️
src/libs/TransactionUtils/fields.ts 100.00% <100.00%> (ø)
src/libs/actions/IOU/BulkEdit.ts 83.90% <100.00%> (ø)
src/libs/actions/IOU/UpdateMoneyRequest.ts 92.20% <100.00%> (ø)
src/libs/actions/Transaction.ts 85.16% <100.00%> (ø)
... and 3 more
... and 7 files with indirect coverage changes

Port the test from Expensify#105846 that getTransactionDetails returns yyyy-MM-dd in
German and Japanese, which the e-receipt now formats itself.
…calize-dates-receipts

# Conflicts:
#	src/libs/TransactionUtils/index.ts
@shubham1206agra
shubham1206agra marked this pull request as ready for review November 7, 2026 13:42
@shubham1206agra
shubham1206agra requested review from a team as code owners November 7, 2026 13:42
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and trjExpensify and removed request for a team November 7, 2026 13:43
@melvin-bot

melvin-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team November 7, 2026 13:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:56:57.929471Z f90bbd7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/libs/DateUtils.ts Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f90bbd79ac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/DateUtils.ts Resolved

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@linhvovan29546

linhvovan29546 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Image
iOS: mWeb Safari
MacOS: Chrome / Safari Image

@roryabraham
roryabraham merged commit 95cbe03 into Expensify:main Nov 10, 2026
37 of 41 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only refactors transaction-date handling and e-receipt date formatting, without adding new interactions, screens, outcomes, user attributes, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR refactors receipt date formatting without adding a user-facing feature, changing a workflow, or making any existing help article sentence incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants