Repository navigation
Localize the hotel cancellation date - #105875
Conversation
Build the date part of getFormattedCancellationDate with a cached Intl.DateTimeFormat on the venue's wall-clock date, so each language uses its own order. The time, the GMT label and the local-time path are unchanged, and English output is the same.
A cached Intl.DateTimeFormat keeps the device timezone from when it was created. Format in UTC and copy the date's current local fields instead.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb SafariMacOS: Chrome / Safaripr105875-cancellation-date.mp4 |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.34-0 🚀
|
|
No help site update needed — this PR fixes hotel cancellation date formatting to match the selected language, restoring expected behavior without changing the workflow or making existing article guidance incorrect. |
|
No FullStory changes needed — this PR only fixes hotel cancellation date localization, without adding new interactions, screens, user properties, or sensitive content. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
The hotel cancellation deadline (
DateUtils.getFormattedCancellationDate) built its date with the hand-written patternEEEE, MMM d[, yyyy]. It fixes the US order, so German showedSonntag, Apr. 19, 2026and Japanese日曜日, 4月 19, 2026.The date part now comes from a cached
Intl.DateTimeFormatin the app's selected language. Everything else is unchanged: the time is still shown in the venue's timezone and follows the language's clock, theGMT+7label is still derived from the offset, and a deadline with no offset still shows the hotel's local time label.The venue's offset (for example
+07:00) is applied with date-fns-tz before formatting rather than passed toIntlas a timeZone, because not every engine accepts a raw offset there. This keeps the date and the time on the same venue-local day.This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order. Each one caches its own
Intl.DateTimeFormatnext to the function it changes; a follow-up will merge those into one shared helper.Fixed Issues
$ #98088
PROPOSAL:
Tests
Sonntag, 19. Apr. 2026followed by a 24-hour time and the GMT label.Sunday, Apr 19, 2026 3:00 PM, GMT+7, the same as before.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-11-05.at.9.39.46.PM.mov