Skip to content

Use the shared abbreviated date for comparison chart day names - #105879

Closed
shubham1206agra wants to merge 1 commit into
Expensify:mainfrom
shubham1206agra:localize-dates-search-chart-buckets
Closed

shubham1206agra wants to merge 1 commit into
Expensify:mainfrom
shubham1206agra:localize-dates-search-chart-buckets

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Search comparison charts name single-day periods (in the legend and tooltip) with a hand-written MMM d, yyyy pattern in comparisonBuckets.ts. That pattern fixes the US order for every language.

These two display-only names now use CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT, the app's abbreviated date with a year. It reads the same today (Aug 1, 2026), and becomes the localized PP date (for example 1. Aug. 2026 in German) through the companion PR that localizes that constant.

The short bucket labels (EEE, do, MMM d) are left as they are, because the chart also compares those formatted values to pair buckets across the two periods.

This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. Open Reports > Expenses, show the chart grouped by day, and turn on comparison with a previous period of less than a week.
  2. Verify the legend and tooltip name each day like Aug 1, 2026, the same as before.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. Formatting is local and does not depend on the network.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Name single-day comparison periods with CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT
instead of a hand-written MMM d, yyyy, so they follow the app's localized date
once that constant is localized. The bucket labels used for pairing are left
unchanged.
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/Search/comparisonBuckets.ts 96.90% <50.00%> (ø)
... and 10 files with indirect coverage changes

@shubham1206agra

Copy link
Copy Markdown
Contributor Author

Closing in favor of #105865, which now includes this change since it only localizes once that PR sets MONTH_DAY_YEAR_ABBR_FORMAT to PP.

@shubham1206agra
shubham1206agra deleted the localize-dates-search-chart-buckets branch November 5, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant