Repository navigation
Use the shared abbreviated date for comparison chart day names - #105879
Closed
shubham1206agra wants to merge 1 commit into
Closed
shubham1206agra wants to merge 1 commit into
shubham1206agra wants to merge 1 commit into
Conversation
Name single-day comparison periods with CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT instead of a hand-written MMM d, yyyy, so they follow the app's localized date once that constant is localized. The bucket labels used for pairing are left unchanged.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
37 tasks done
Contributor
Author
|
Closing in favor of #105865, which now includes this change since it only localizes once that PR sets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Search comparison charts name single-day periods (in the legend and tooltip) with a hand-written
MMM d, yyyypattern incomparisonBuckets.ts. That pattern fixes the US order for every language.These two display-only names now use
CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT, the app's abbreviated date with a year. It reads the same today (Aug 1, 2026), and becomes the localizedPPdate (for example1. Aug. 2026in German) through the companion PR that localizes that constant.The short bucket labels (
EEE,do,MMM d) are left as they are, because the chart also compares those formatted values to pair buckets across the two periods.This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order.
Fixed Issues
$ #98088
PROPOSAL:
Tests
Aug 1, 2026, the same as before.Offline tests
Same as tests. Formatting is local and does not depend on the network.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari