Skip to content

Localize time zone names - #105880

Merged
roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-zone-names
Nov 7, 2026
Merged

roryabraham merged 6 commits into
Expensify:mainfrom
shubham1206agra:localize-dates-zone-names

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

DateUtils.getZoneAbbreviation named the user's timezone without a locale, so the zone name was always the English one, for example EDT or GMT+2, in every language.

It now passes the app's selected language to date-fns-tz, which gets the zone name from Intl. Each language then uses its own name for the zone:

Zone (in June) English German Japanese French
America/New_York EDT (unchanged) GMT-4 GMT-4 UTC−4
Europe/Berlin GMT+2 (unchanged) MESZ GMT+2 UTC+2
Asia/Tokyo GMT+9 (unchanged) GMT+9 JST UTC+9

Places updated:

  • The local time shown on a user's profile (AutoUpdateTime)
  • The scheduled call time in the onboarding help dropdown
  • The call time on the schedule call confirmation page

This is one of a set of small, independent PRs that split up the date-localization work in #105846. They can merge in any order.

Update: lint rule covers timezone names

The require-locale-for-localized-date-format rule now treats the timezone name tokens (z, zz, zzz, zzzz) as language-dependent, since Intl names the zone in the locale's language: New York reads EDT in English, GMT-4 in German and UTC−4 in French. The O and OOOO offset tokens read GMT-4 in every language, so they are not included. getZoneAbbreviation was the only call that formatted a zone name, and this PR already passes the locale to it, so the rule finds no other violations. tests/unit/RequireLocaleForLocalizedDateFormatRuleTest.ts covers both cases.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. With a second account, set its timezone to Europe/Berlin in Settings > Profile > Timezone.
  2. On your account, open Settings > Preferences > Language and select Deutsch.
  3. Open the second account's profile and verify its local time shows the German zone name (for example MESZ in summer).
  4. Switch back to English and verify the zone name reads as before (for example GMT+2).
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

105880-confirm-de 105880-confirm-en 105880-confirm-fr 105880-header-de 105880-header-en 105880-header-fr 105880-profile-de 105880-profile-en 105880-profile-fr

Pass the app's language to getZoneAbbreviation so each language uses its own
name for the zone. English zone names are unchanged. The local time on
profiles, the scheduled call in the onboarding help dropdown and the schedule
call confirmation now pass the locale.
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/AutoUpdateTime.tsx 77.77% <100.00%> (ø)
src/components/OnboardingHelpDropdownButton.tsx 96.66% <100.00%> (ø)
src/libs/DateUtils.ts 90.17% <100.00%> (ø)
...ages/ScheduleCall/ScheduleCallConfirmationPage.tsx 90.32% <100.00%> (ø)
... and 9 files with indirect coverage changes

The z tokens name the zone through Intl in the locale's language, so
they need the user's locale. The O offset tokens read the same in every
language and are left out.
@shubham1206agra
shubham1206agra marked this pull request as ready for review November 5, 2026 15:36
@shubham1206agra
shubham1206agra requested review from a team as code owners November 5, 2026 15:36
@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and removed request for a team November 5, 2026 15:36
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team November 5, 2026 15:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T15:58:44.442176Z 097301d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 097301dfe5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Plain date-fns writes a GMT offset for the z tokens in every language;
only date-fns-tz names the zone through Intl in the locale's language.
@linhvovan29546

Copy link
Copy Markdown
Contributor

@shubham1206agra Conflicts

…calize-dates-zone-names

# Conflicts:
#	eslint-plugin-local-rules/require-locale-for-localized-date-format.js
#	tests/unit/DateUtilsTest.ts
#	tests/unit/RequireLocaleForLocalizedDateFormatRuleTest.ts
Comment thread tests/unit/DateUtilsTest.ts Resolved
Comment thread src/libs/DateUtils.ts Resolved
@linhvovan29546

linhvovan29546 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Image
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-07.at.18.06.41.mov

@roryabraham
roryabraham merged commit 68efe8d into Expensify:main Nov 7, 2026
39 of 41 checks passed
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Nov 7, 2026
85 tasks done
@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only fixes timezone-name localization in existing UI and adds lint/test coverage, without introducing new interactions, screens, user-property values, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this fixes timezone names to match the selected language without adding a workflow or making existing article instructions incorrect.


view run

@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants