Skip to content

[No QA] Make subscription and search date tests timezone-independent - #105886

Closed
shubham1206agra wants to merge 1 commit into
Expensify:mainfrom
shubham1206agra:fix-timezone-dependent-date-tests
Closed

shubham1206agra wants to merge 1 commit into
Expensify:mainfrom
shubham1206agra:fix-timezone-dependent-date-tests

Conversation

@shubham1206agra

@shubham1206agra shubham1206agra commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Two test suites only passed when Jest ran in UTC:

  • SubscriptionUtilsTest built its subscription NVP fixtures with date-fns format, which uses the device's timezone. The helpers under test read those values back as UTC (by appending Z), so on a machine outside UTC the fixtures were off by the offset, and the assertions that compare within a day failed. The fixtures are now formatted in UTC.
  • SearchQueryUtilsTest pinned "now" to 12:00Z. Presets such as year-to-date resolve "today" in the user's own zone, so past UTC+12 the clock lands on the next local day and the expected range shifts. It is now pinned to local noon.

npm test sets TZ=utc, so CI was not affected, but running a single test file with npx jest on a machine outside UTC failed. Both suites now pass in UTC, Asia/Calcutta, America/Los_Angeles and Pacific/Kiritimati.

This is test-only and was split out of the date-localization work in #105846.

Fixed Issues

$ #98088
PROPOSAL:

Tests

  1. Run TZ=Asia/Calcutta npx jest tests/unit/SubscriptionUtilsTest.ts tests/unit/Search/SearchQueryUtilsTest.ts and verify both pass.
  2. Run the same with TZ=Pacific/Kiritimati and TZ=America/Los_Angeles and verify both pass.
  • Verify that no errors appear in the JS console

Offline tests

N/A, test-only change.

QA Steps

[No QA] Test-only change.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Build the subscription fixtures in UTC, since the helpers read the NVPs back as
UTC, and pin the search preset clock to local noon so it stays on the same day
in timezones ahead of UTC+12. Both suites now pass outside UTC.
@shubham1206agra
shubham1206agra deleted the fix-timezone-dependent-date-tests branch November 4, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant