Repository navigation
[No QA] Fix TravelTest call to the removed Onyx.disconnect - #106267
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
yuwenmemon
requested review from
stitesExpensify
and removed request for
inimaga
November 6, 2026 21:55
roryabraham
approved these changes
Nov 6, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
mountiny
approved these changes
Nov 6, 2026
tylerkaraszewski
approved these changes
Nov 6, 2026
85 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.34-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stitesExpensify please review
Explanation of Change
TravelTest.tscallsOnyx.disconnect(), whichreact-native-onyxno longer has, so typecheck, Oxlint and Jest fail onmainand on every open PR. This usesconnection.unsubscribe(), like the other tests that callOnyx.connect(). The call came in with #99426.Fixed Issues
$ #99426
PROPOSAL: N/A
Tests
npm run typecheckand confirm it passes.npx jest tests/actions/TravelTest.tsand confirm all tests pass.Offline tests
N/A, test-only change.
QA Steps
No QA, test-only change.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari