Repository navigation
[Payment due @bernhardoj] Use canSkipVerification from RequestTravelAccess so verified admins can enable travel - #99426
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ab0411df5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Couple of bot comments. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
FYI I can't approve that account until https://github.com/Expensify/Web-Expensify/pull/57964 is on staging |
|
You should be approved now @bernhardoj
|
|
@stitesExpensify thanks! Can you help me block that now? I want to test the last case. |
|
Blocked! |
|
Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @bernhardoj, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR only fixes existing travel-access routing and error handling, without adding a new feature, screen, user-property value, or sensitive content. |
|
No help site update needed — this PR fixes existing travel-access routing so eligible admins can complete setup as expected, without adding a new workflow or removing a beta gate. |
|
@stitesExpensify @tylerkaraszewski @joekaufmanexpensify QA team is not able to use Supportal. Can you please QA this internally? |
|
We don't have a private domain that we can test this with, I just need to watch the logs. This can be checked off |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #106429 |


Explanation of Change
When a workspace isn't set up for travel yet and the admin isn't in the
isTravelVerifiedbeta, Book a trip now waits forRequestTravelAccessand sends low-risk and travel-risk-approved admins straight to travel enablement, the same as beta users. Previously the response was ignored, so these admins were told their company was being verified even though no review was opened, and travel was never enabled. Admins who do need a review still get the existing review flow, and if the request fails, the button shows a generic error instead.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/666864
PROPOSAL:
Tests
isTravelVerifiedbeta.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avatar, I verified the components usingAvatarare working as expected)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested.
Android: mWeb Chrome
Not tested.
iOS: Native
Not tested.
iOS: mWeb Safari
Not tested.
MacOS: Chrome / Safari
Not tested.