Skip to content

[Payment due @bernhardoj] Use canSkipVerification from RequestTravelAccess so verified admins can enable travel - #99426

Merged
tylerkaraszewski merged 14 commits into
mainfrom
stites-travelRiskApprovalBridge
Nov 6, 2026
Merged

tylerkaraszewski merged 14 commits into
mainfrom
stites-travelRiskApprovalBridge

Conversation

@stitesExpensify

@stitesExpensify stitesExpensify commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When a workspace isn't set up for travel yet and the admin isn't in the isTravelVerified beta, Book a trip now waits for RequestTravelAccess and sends low-risk and travel-risk-approved admins straight to travel enablement, the same as beta users. Previously the response was ignored, so these admins were told their company was being verified even though no review was opened, and travel was never enabled. Admins who do need a review still get the existing review flow, and if the request fails, the button shows a generic error instead.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/666864
PROPOSAL:

Tests

  1. Sign in as a validated admin of a Collect or Control workspace on a private domain that has not enabled travel, and make sure the account is not in the isTravelVerified beta.
  2. In Supportal, go to Travel > Set Travel Risk Approved and approve that domain.
  3. In NewDot, open the workspace's Travel page and press Let's go.
  4. Verify the travel enablement steps open.
  5. Sign in as a brand-new validated admin of a Collect workspace on a different private domain, not in the beta, not approved, and with no earlier travel request (a pending request is stored on the account, so it shows on every workspace).
  6. Open the workspace's Travel page and press Let's go.
  7. Verify the Travel page switches to show the request was sent and is being reviewed. This page doesn't show the verify-company modal.
  8. Sign in as a third validated admin of a Collect workspace on another private domain, not in the beta.
  9. In Supportal, go to Travel > Block Travel and block that account.
  10. Open the workspace's Travel page and press Let's go.
  11. Verify a "something went wrong" error appears under the button, and the enablement steps don't open.
  • Verify that no errors appear in the JS console

Offline tests

  1. As the admin from step 1 of Tests, go offline.
  2. Open the workspace's Travel page and press Let's go.
  3. Verify a "something went wrong" error appears under the button, and the enablement steps don't open.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested.

Android: mWeb Chrome

Not tested.

iOS: Native

Not tested.

iOS: mWeb Safari

Not tested.

MacOS: Chrome / Safari

Not tested.

@stitesExpensify
stitesExpensify requested review from a team as code owners August 25, 2026 13:07
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and parasharrajat and removed request for a team August 25, 2026 13:07
@melvin-bot

melvin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 25, 2026 13:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ab0411df5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov

codecov Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/actions/Travel.ts 76.92% <100.00%> (+21.92%) ⬆️
src/components/BookTravelButton.tsx 91.30% <95.65%> (+0.21%) ⬆️
... and 5 files with indirect coverage changes

@parasharrajat

Copy link
Copy Markdown
Member

Couple of bot comments.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@stitesExpensify
stitesExpensify marked this pull request as draft August 25, 2026 21:34
@stitesExpensify stitesExpensify changed the title Use travel risk approval during travel enablement Use canSkipVerification from RequestTravelAccess so verified admins can enable travel Oct 16, 2026
@stitesExpensify
stitesExpensify marked this pull request as ready for review October 16, 2026 20:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T20:33:09.116322Z f94a0db Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/types/onyx/TravelSettings.ts Resolved
@stitesExpensify

Copy link
Copy Markdown
Contributor Author

FYI I can't approve that account until https://github.com/Expensify/Web-Expensify/pull/57964 is on staging

@stitesExpensify

Copy link
Copy Markdown
Contributor Author

You should be approved now @bernhardoj

2026-11-04_17-56-30

@bernhardoj

Copy link
Copy Markdown
Contributor

@stitesExpensify thanks! Can you help me block that now? I want to test the last case.

@stitesExpensify

Copy link
Copy Markdown
Contributor Author

Blocked!

@bernhardoj

Copy link
Copy Markdown
Contributor

Thanks!

@bernhardoj

bernhardoj commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari image
skip.mp4
blocked.mp4

@melvin-bot
melvin-bot Bot requested a review from tylerkaraszewski November 6, 2026 03:51
@melvin-bot

melvin-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title Use canSkipVerification from RequestTravelAccess so verified admins can enable travel [Payment due @bernhardoj] Use canSkipVerification from RequestTravelAccess so verified admins can enable travel Nov 6, 2026
@melvin-bot

melvin-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

🎯 @bernhardoj, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/666864.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@tylerkaraszewski
tylerkaraszewski merged commit 64c63ea into main Nov 6, 2026
48 of 50 checks passed
@tylerkaraszewski
tylerkaraszewski deleted the stites-travelRiskApprovalBridge branch November 6, 2026 20:37
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🚧 tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.5.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only fixes existing travel-access routing and error handling, without adding a new feature, screen, user-property value, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes existing travel-access routing so eligible admins can complete setup as expected, without adding a new workflow or removing a beta gate.


view run

@mvtglobally

Copy link
Copy Markdown

@stitesExpensify @tylerkaraszewski @joekaufmanexpensify QA team is not able to use Supportal. Can you please QA this internally?

@stitesExpensify

Copy link
Copy Markdown
Contributor Author

We don't have a private domain that we can test this with, I just need to watch the logs. This can be checked off

@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #106429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants