Repository navigation
[No QA] Prevent setting a pusher suffix for the staging or production api - #13297
Merged
Merged
Conversation
neil-marcellini
marked this pull request as ready for review
December 2, 2022 23:48
melvin-bot
Bot
requested review from
Luke9389 and
rushatgabhane
and removed request for
a team
December 2, 2022 23:48
|
@rushatgabhane @Luke9389 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
FYI, there's no need to test on all platforms because I only modified a script. |
Contributor
|
Removing Rushat just b/c this is an internal PR - I don't think C+ have pusher suffixes |
Beamanator
approved these changes
Dec 5, 2022
Contributor
Author
|
@Beamanator Would you please fill out the reviewer checklist? It should be easy since most of it doesn't apply. |
Contributor
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
72 tasks done
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Beamanator since you expressed interest in this
Details
When testing on dev against the staging or production API, the
set-pusher-suffixscript adds a dev pusher suffix, which means that Pusher won't work correctly.I have modified this script so that it does nothing if we are pointing to the staging or production API. To determine that I looked at the value of
EXPENSIFY_URLin the .env file because it is set tohttps://www.expensify.com/on staging and production, andhttps://www.expensify.com.dev/on dev.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/244501
PROPOSAL: N/A
Tests
Set up NewDot dev to hit the staging API, then make sure Pusher works.
.envfile to.env.dev.env.stagingto.envnpm run desktop.envand make sure a pusher dev suffix was not addedShell tests
With a
.envfile.envfile is set up (copy fromenv.exampleif needed).env(if it exists)scripts/set-pusher-suffix.shWithout one
.envfile to.env.devso that you don't have a.envfilescripts/set-pusher-suffix.sh.envfile is created and the pusher suffix is addedOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
All platforms aside from Desktop are not applicable.
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
pusher-suffix-staging.mov
iOS
Android