Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.2.37-0
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Remove clipped texts throughout the app when device font size is increased #10312
- fix "Closing split bill doesn't refocus on composer" on web/desktop #12031
- Update the chat UI to reflect drag-and-drop #12056
- Run e2e performance regression tests on merge into
mainvia AWS Device farm #12320 - Only generate optimistic IOU report if no existing iouReportID #12759
- Fix the keyboard overlapping buttons on the sign in form #12848
- keep focus on composer when expand/collapse button is clicked #12949
- Scroll to the right spot when clicking "Fix Errors" #12954
- Core Branding: Update Compose Bar #12965
- LHN order improvements #12978
- Defaulting sandboxing to false #13045
- Rename lastVisitedTimestamp to lastReadTimestamp #13128
- Fix green outline at checkbox #13181
- make save button clickable even when the keyboard is open #13189
- Adapt status bar color to modal backdrop #13215
- fix "FAB menu and sidebar can be opened at the same time" #13226
- Revert "fix: 11584 web jump to unread message" #13230
- Fix blue highlight issue by disabling autoCorrect #13231
- Webpack - extract separate vendors chunk for better caching #13235
- Updated react-native-image-picker to 4.10.2 #13246
- Relax check for reviewer checklist #13247
- Keep message highlighted when right clicking #13249
- Blur login page input only when transitioned to magic link page #13265
- Fix spelling error in Form.md doc #13268
- Update style in attachment preview to match the new theme #13270
- Rename docs/articles/send-money/Everything-About-Chat.md to docs/arti… #13272
- Change background color for mWeb scrolling #13278
- Correct the logic for when bill split particpants can be selected #13279
- Update Onfido to latest to resolve deploy issues #13284
- make emoji button hover background round #13288
- [No QA] Prevent setting a pusher suffix for the staging or production api #13297
- [CP Staging] Changed border style #13298
- Clean up the code when adding colors for the Picker #13299
- Wait for the drawer to be ready before loading the left navigation #13301
- Fix overlap for edit text view #13302
- fix: alter expensify-datepicker class #13316
- Cleanup props and callbacks for OptionsList #13319
- Improvements for TestBuild workflow #13321
- Dark Mode Focused state correct colour #13328
- Remove right icon from Electron notifications. #13330
- change display name color to gray #13331
- Fix proptype error in AddDebitCard page #13345
- Fix
cannot read property inputID of undefined#13348 - Ensure correct background is present for
horizontalStackedAvatarstyle #13351 - Update Fastfile for iOS build_internal #13355
- [NoQA] [TEST] Internal QA #13356
- [NoQA] [TEST] Internal QA 2 #13357
- [NoQA] [TEST] Internal QA 3 #13358
- [NoQA] [TEST] Internal QA 4 #13359
- [NoQA] [TEST] Internal QA 5 #13360
- [NoQA] [TEST] Internal QA 6 #13361
- [NoQA] [TEST] Internal QA 7 #13362
- [NoQA] [TEST] Internal QA 8 #13363
- [NoQA] [TEST] Internal QA 9 #13364
- Fix for: Zooming out using the slider bar in edit photo does not properly display the image #13365
- [NO QA] Add airship file to unblock failing internalRelease builds #13370
- [No QA]Add missing token to fix e2e tests run on merge #13371
- [No QA]Run
npm installbefore building each build #13374 - Branding: Use New Wordmark Logo #13383
- [No QA] Lint bash scripts with shellcheck #13387
- Update baseTextInput line height to prevent cutoff #13389
- Clear request queue and reconnection callbacks upon sign out #13393
- Update expensify-common dependency #13394
- Revert "Display banner to enable 2FA when setting up VBBA" #13407
- Refactor the function for filtering the currency list #13412
Internal QA:
Deploy Blockers:
- Dev - mWeb - App crashes on sign in #13473
- [HOLD for payment 2022-12-20] [$1000] Profile : Upload/Delete Photo popup not hiding #13435
- Account - Message 'Account closed successfully" doesn't appear #13466
- Log in - Error message “Too many attempts doesn't appeared and info is blinking when tap on resend link #13447
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Dec 8, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.37-0 🚀
aldo-expensify commentedon Dec 8, 2022
I checked off #13247
because I think it needs to be QA'ed in production.Update: I QA'ed this here and it was a pass
mvtglobally commentedon Dec 8, 2022
@francoisl
We are still working on PRs and regression, but meanwhile sharing initial summary
PR #13351 is failing #13446. Issue is closed so checking off
PR #13330 is failing #13392
PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.
PR #13278 is failing #13085
PR #13246 is failing #13246
PR #12965 is failing #13443. Repro in PROD
PR #12949 is failing #11093. Older KI
PR #12031 is failing #10888. Older KI
francoisl commentedon Dec 9, 2022
Thanks!
This one appears fixed to me, can you please post a screenshot (either here or in the PR)
I only checked on desktop, but this one also appears to be fixed to me. Can you provide a recording please?
I'm going to confirm, but I think these are somewhat separate issues and we can check 12965
This one also looks fine to me, and Android (native & mWeb). Going to ask someone to check iOS
I'm finishing checking the others and will update this post later.
mvtglobally commentedon Dec 9, 2022
Additional Summary
@francoisl Will get screenshots on above in a bit
These are 3 Blockers
#13447
#13435
#13436
PRs
PR #12056 is failing #13458. Its not repro in PROD as its a new feature. Pls double check its not a blocker
PR #12759 is failing #10550 very intermittent and probably not related to PR. Checking off
This one also looks fine to me, and Android (native & mWeb). Going to ask someone to check iOS
--- PR #12949 ONLY failing on mWeb / Chrome (https://platform.applause.com/services/links/v1/external/b4c75e86778c3bcacfa4784a7f2f6abddc51e94f1e1abf66a3a197acc790dc2b)
PR #12965 checking off
PR #13189 is failing #13457. repro in PROD checking off
PR #13230 is failing #11584. Old KI
PR #13246 is failing #13454 repro in PROD. As its related to a new feature. Pls double check its not a blocker
mountiny commentedon Dec 9, 2022
Checking #13029 (comment) off, it works well in staging 🎉
mvtglobally commentedon Dec 9, 2022
Regression is Completed @francoisl
Final Summary of outstanding items reconciled previous posts
Open Deploy Blockers
#13435
#13466
Open PRs
PR #12031 is failing #10888. Older KI. Repro in PROD checking off
PR #12056 is failing #13458. Its not repro in PROD as its a new feature. Pls double check its not a blocker
PR #12949 ONLY failing on mWeb / Chrome (https://platform.applause.com/services/links/v1/external/b4c75e86778c3bcacfa4784a7f2f6abddc51e94f1e1abf66a3a197acc790dc2b) OK to check off?
PR #13230 is failing #11584. Old KI, repro in PROD checking off
PR #13246 is failing #13454 repro in PROD. As its related to a new feature. Pls double check its not a blocker
PR #13278 is failing #13085 (Video)
PR #13319 is failing #12551. repro in PROD. checking off
PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.
PR #13330 is failing #13392 Are we ok to check off?
francoisl commentedon Dec 9, 2022
Confirmed here, not a blocker. Going to check this off.
Looks like the PR is not fully working then. I commented here to get some opinion from the participants.Can no longer reproduce after a hard refresh, going to check it off.Seems specific to Windows, let's check this off for now and we'll fix it later. No need to block the deploy for this.
The issue was closed and this seems like expected behavior. Checking this off.
Yes this looks like the correct color, #5AB0FF. Same as on the screenshots in the reviewer post. Going to check it off
Yes based on this conversation, I'm going to check it off as well
francoisl commentedon Dec 9, 2022
francoisl commentedon Dec 10, 2022
v1.2.37-2 QA'ed internally and it resolves #13466, we're good to go.
francoisl commentedon Dec 10, 2022