Skip to content

Deploy Checklist: New Expensify 2022-12-07 #13431

Closed

Description

@francoisl

Release Version: 1.2.37-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Dec 8, 2022

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.37-0 🚀

  2. aldo-expensify commented on Dec 8, 2022

    @aldo-expensify
    Contributor

    I checked off #13247 because I think it needs to be QA'ed in production.

    Update: I QA'ed this here and it was a pass

  3. mvtglobally commented on Dec 8, 2022

    @mvtglobally

    @francoisl

    We are still working on PRs and regression, but meanwhile sharing initial summary

    PR #13351 is failing #13446. Issue is closed so checking off
    PR #13330 is failing #13392
    PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.
    PR #13278 is failing #13085
    PR #13246 is failing #13246
    PR #12965 is failing #13443. Repro in PROD
    PR #12949 is failing #11093. Older KI
    PR #12031 is failing #10888. Older KI

  4. francoisl commented on Dec 9, 2022

    @francoisl
    ContributorAuthor

    Thanks!

    PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.

    This one appears fixed to me, can you please post a screenshot (either here or in the PR)

    PR #13278 is failing #13085

    I only checked on desktop, but this one also appears to be fixed to me. Can you provide a recording please?

    PR #12965 is failing #13443. Repro in PROD

    I'm going to confirm, but I think these are somewhat separate issues and we can check 12965

    PR #12949 is failing #11093. Older KI

    This one also looks fine to me, and Android (native & mWeb). Going to ask someone to check iOS


    I'm finishing checking the others and will update this post later.

  5. mvtglobally commented on Dec 9, 2022

    @mvtglobally

    Additional Summary
    @francoisl Will get screenshots on above in a bit

    These are 3 Blockers
    #13447
    #13435
    #13436

    PRs
    PR #12056 is failing #13458. Its not repro in PROD as its a new feature. Pls double check its not a blocker
    PR #12759 is failing #10550 very intermittent and probably not related to PR. Checking off

    PR #12949 is failing #11093. Older KI

    This one also looks fine to me, and Android (native & mWeb). Going to ask someone to check iOS

    --- PR #12949 ONLY failing on mWeb / Chrome (https://platform.applause.com/services/links/v1/external/b4c75e86778c3bcacfa4784a7f2f6abddc51e94f1e1abf66a3a197acc790dc2b)

    PR #12965 checking off
    PR #13189 is failing #13457. repro in PROD checking off
    PR #13230 is failing #11584. Old KI
    PR #13246 is failing #13454 repro in PROD. As its related to a new feature. Pls double check its not a blocker

  6. mountiny commented on Dec 9, 2022

    @mountiny
    Contributor

    Checking #13029 (comment) off, it works well in staging 🎉

  7. mvtglobally commented on Dec 9, 2022

    @mvtglobally

    Regression is Completed @francoisl

    Final Summary of outstanding items reconciled previous posts

    Open Deploy Blockers
    #13435
    #13466

    Open PRs
    PR #12031 is failing #10888. Older KI. Repro in PROD checking off
    PR #12056 is failing #13458. Its not repro in PROD as its a new feature. Pls double check its not a blocker
    PR #12949 ONLY failing on mWeb / Chrome (https://platform.applause.com/services/links/v1/external/b4c75e86778c3bcacfa4784a7f2f6abddc51e94f1e1abf66a3a197acc790dc2b) OK to check off?
    PR #13230 is failing #11584. Old KI, repro in PROD checking off
    PR #13246 is failing #13454 repro in PROD. As its related to a new feature. Pls double check its not a blocker
    PR #13278 is failing #13085 (Video)
    PR #13319 is failing #12551. repro in PROD. checking off
    PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.

    This one appears fixed to me, can you please post a screenshot (either here or in the PR)
    VIDEO & Screenshot

    PR #13330 is failing #13392 Are we ok to check off?

  8. francoisl commented on Dec 9, 2022

    @francoisl
    ContributorAuthor

    PR #12056 is failing #13458. Its not repro in PROD as its a new feature. Pls double check its not a blocker

    Confirmed here, not a blocker. Going to check this off.

    PR #12949 ONLY failing on mWeb / Chrome

    Looks like the PR is not fully working then. I commented here to get some opinion from the participants. Can no longer reproduce after a hard refresh, going to check it off.

    PR #13278 is failing #13085 (Video)

    Seems specific to Windows, let's check this off for now and we'll fix it later. No need to block the deploy for this.

    PR #13246 is failing #13454 repro in PROD. As its related to a new feature. Pls double check its not a blocker

    The issue was closed and this seems like expected behavior. Checking this off.

    PR #13328 is failing #13256. Its an older issue but was supposed to be fixed.
    VIDEO & Screenshot

    Yes this looks like the correct color, #5AB0FF. Same as on the screenshots in the reviewer post. Going to check it off

    PR #13330 is failing #13392 Are we ok to check off?

    Yes based on this conversation, I'm going to check it off as well

    • I QA'ed the fix for 13435 internally, checking off
  9. francoisl commented on Dec 9, 2022

    @francoisl
    ContributorAuthor
  10. francoisl commented on Dec 10, 2022

    @francoisl
    ContributorAuthor

    v1.2.37-2 QA'ed internally and it resolves #13466, we're good to go.

  11. francoisl commented on Dec 10, 2022

    @francoisl
    ContributorAuthor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions