Repository navigation
fix: alter expensify-datepicker class - #13316
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
47f3e00 to
b690ab8
Compare
There was a problem hiding this comment.
Can you please update padding to address this comment.
sobitneupane
left a comment
There was a problem hiding this comment.
Screen Recording is missing for IOS in PR body. Can you please update it to include screen recording for IOS as well.
b690ab8 to
3d9af3d
Compare
|
@sobitneupane Thanks for the comments, changes addressed. PTAL 🙏 I also altered the font size (calendar icon's size) to be the same as the other icons - as it was around 5-6px smaller before. If we keep the icon smaller than the others, combined with the padding that we have right now ( Thus, I increased the size of the calendar icon - so all icons have a uniform size. Thanks. |
|
@shonsirsha There are different factors that determine the font size of elements. So, comparing in one platform and using a value is not the right option. Let's not change the font size. |
3d9af3d to
9e3a17d
Compare
Hi, sure! 🙂 reverted |
|
Oops, I re-requested review and it automatically removed @deetergp from the reviewers list. Please feel free to add yourself in again if it's necessary (as I can't do so atm). Thanks! |
|
Hey, sorry for spamming but do we have any updates here? 🙂 Please lmk if I'm missing something, thanks. |
There was a problem hiding this comment.
| padding: 18px 9px; | |
| padding: 18px 13px; |
There was a problem hiding this comment.
Looks like having 13px makes more sense. As it will be aligned to center of the dropdown pointer icons. Sorry for the confusion.
There was a problem hiding this comment.
No probs! Change has been made 🙂
9e3a17d to
c87353e
Compare
|
Hey 👋 , I believe we are good here..? Any possibility to get an approval or any updates? Sorry, it's my first PR to this repo - is something else needs to be done from my side? 🙂 |
deetergp
left a comment
There was a problem hiding this comment.
Changes look good, but you need to sign the CLA @shonsirsha and @sobitneupane needs to compete the reviewer checklist in order for the tests to pass so that the PR can be merged.
Reviewer Checklist
Screenshots/Videos |
|
Actually, it looks like it's on me to complete the checklist, so I'll do so now. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks a lot @deetergp! Seems like like I have sucessfully signed the CLA. The check in this PR is still failing though. How does one re-run this check? |
|
Okay, all the tests are passing. All that's left now is for @sobitneupane to approve. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀
|

















Details
When date picker is visible (normally on desktop app & desktop web), date picker icon should be centred (vertically) and its touchable/clickable area should be increased.
Fixed Issues
$ 12957
PROPOSAL: GH_LINK_ISSUE (COMMENT) - a super slight modification of it.
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Web
Screen.Recording.2022-12-04.at.17.34.13.mov
Mobile Web - Chrome
Screen.Recording.2022-12-04.at.18.50.04.mov
Mobile Web - Safari
MWEB.MP4
Desktop
Screen.Recording.2022-12-04.at.18.24.33.mov
iOS
Screen.Recording.2022-12-05.at.05.33.41.mov
Android
Screen.Recording.2022-12-04.at.18.54.15.mov