Repository navigation
[NO QA] Just QAing - #13442
Closed
aldo-expensify wants to merge 1 commit into
Closed
[NO QA] Just QAing#13442aldo-expensify wants to merge 1 commit into
aldo-expensify wants to merge 1 commit into
Conversation
aldo-expensify
marked this pull request as ready for review
December 8, 2022 20:05
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
December 8, 2022 20:06
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
This is me copy pasting another PR reviewer checklist and adding content at the top. I changed also the header type for reviewer checklist Reviewer Checklist
Screenshots/Videos |
Contributor
Author
|
@marcochavezf Can you approve this PR (don't merge) to trigger the PR reviewer checklist and add a comment with the checklist with this content: #13442 (comment) |
marcochavezf
approved these changes
Dec 8, 2022
Contributor
|
Test comment Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Contributor
Author
|
Ok, it seems to have found my initial comment: We could say that this checklist should ignore comments from the PR author hehe, but that was working like that already and I don't think it will ever cause a problem. Thanks @marcochavezf |
This was referenced Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








QAing this: #13247
Details
Fixed Issues
$ GH_LINK
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android