Repository navigation
Delete modal confirmation did not change prefered locale - #13859
Conversation
|
@eVoloshchak @madmax330 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@eVoloshchak bump 🙇🏼 |
Hmm, weird, I haven't received notifications from this PR even though melvin has tagged me previously |
|
@eVoloshchak I think it might be due to a change in process, let us know if this happens again, thanks for jumping in |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-01-02.at.13.09.25.movMobile Web - ChromeNot able to test due to an issue with not being able to log in, using a video for web Screen.Recording.2023-01-02.at.13.09.25.movMobile Web - SafariNot able to test due to an issue with not being able to log in, using a video for web Screen.Recording.2023-01-02.at.13.09.25.movDesktopScreen.Recording.2023-01-02.at.13.15.23.moviOSScreen.Recording.2023-01-02.at.13.13.45.movAndroidScreen.Recording.2023-01-02.at.13.27.11.mov |
eVoloshchak
left a comment
There was a problem hiding this comment.
Looks good and tests well
Wasn't able to test mWeb due to an issue with not being able to log in, included video from Web instead in screenshots section
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @sketchydroide in version: 1.2.47-0 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.2.47-0 🚀
|
Details
Fixed Issues
$ #13780
Tests
DeleteorEliminarOffline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android