Repository navigation
Migrate ReportActionsView.js to function component - #22200
neil-marcellini merged 8 commits into
Conversation
|
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@narefyev91 could you review this PR please? |
…lace ReportScrollManager with useReportScrollManager hook
|
I replaced ReportScrollManager with userReportScrollManager hook as suggested here #16267 (comment) |
|
@narefyev91 could you review please? |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
narefyev91
left a comment
There was a problem hiding this comment.
LGTM
🎀 👀 🎀 C+ reviewed
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #16267 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Sorry, but I have a last request for the change. Can we remove ReportScrollManager file? The last usage of ReportScrollManager is in ReportActionsView, but as we already replace it with the hook, we don't need ReportScrollManager anymore. |
|
@bernhardoj I removed ReportScrollManager files as you suggest. |
|
thanks! |
|
@neil-marcellini could you review this PR please? |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looking pretty great! I do have some questions and small changes requested.
…ecessary from useEffect deps
|
@neil-marcellini could you review please? |
neil-marcellini
left a comment
There was a problem hiding this comment.
Thanks for the changes after my last review. It's good to go except one thing that got left out during the refactor.
|
@rayane-djouah if you want another review today please send me a message one NewDot when it's ready. |
|
@neil-marcellini its ready for another review |
7e6b668 to
7fbef95
Compare
7fbef95 to
2ca339e
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.38-0 🚀
|
|
Possible regression here, please take a look |
|
@neil-marcellini @narefyev91 should we revert the PR? |
|
@rayane-djouah I think you need to raise a new PR for this fix. |
|
we are facing issue understanding the steps. Can someone confirm the below is correct?
|
|
@mvtglobally here is a clarification:
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|
|
Hi! Just wanted to leave a comment on this issue regarding this regression. #22426. The issue was caused because of this if condition: In this if condition, we should have used didSubscribeToReportTypingEvents.current as didSubscribeToReportTypingEvents is a useRef value: |
|
Oh shoot we totally missed that. Thanks for the explanation! Typescript will save us soon! |
Details
Fixed Issues
$ #16267
PROPOSAL: #16267 (comment)
Tests
If a report is manually marked as unread, the component should update the new marker position.
Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
Same as tests above.
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mp4
Mobile Web - Chrome
chrome.mp4
Mobile Web - Safari
safari.mp4
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4