Skip to content

Deploy Checklist: New Expensify 2023-07-07 #22399

Closed

Description

@OSBotify

Release Version: 1.3.38-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Jul 7, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.38-3 🚀

  2. melvin-bot commented on Jul 7, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  3. Julesssss commented on Jul 7, 2023

    @Julesssss
    Contributor

    Checking off #22398, after the fix was cherry-picked.

  4. mvtglobally commented on Jul 10, 2023

    @mvtglobally

    Regression is still in progress. We have only 2% left in TR.

    Current PR summary
    #19906 Pending validation on all platforms
    #21482 Pending validation on all platforms
    #21781 Pending validation on all platforms
    #21877 Pending validation on all platforms
    #21941 is failing due to #21941
    #21945 Pending validation on all platforms
    #22100 is failing due to #21001
    #22151 Pending validation on all platforms
    #22188 is failing #22480
    #22200 Pending validation on all platforms
    #22244 Pending validation on all platforms
    #22246 Pending validation on all platforms
    #22253 Pending validation on all platforms
    #22262 Pending validation on all platforms
    #22269 Pending validation on all platforms
    #22275 Pending validation on all platforms
    #22280 Pending validation on all platforms
    #22281 Pending validation on all platforms
    #22327 Pending validation on all platforms

  5. Julesssss commented on Jul 10, 2023

    @Julesssss
    Contributor

    @cristipaval I checked off #22469 as you closed it 👍

  6. cristipaval commented on Jul 10, 2023

    @cristipaval
    Contributor

    @cristipaval I checked off #22469 as you closed it 👍

    Thanks, sorry for missing to check it off here 🙇

  7. mvtglobally commented on Jul 10, 2023

    @mvtglobally

    Regression in TR is completed, down to just a few validations

    Current PR summary
    #21781 Pending validation on all platforms
    #21941 is failing due to #22554
    #22100 is failing due to #21001
    #22188 is failing #22480
    #22253 Pending validation on all platforms
    #22275 Pending validation on all platforms
    #22327 Pending validation on all platforms

  8. Li357 commented on Jul 10, 2023

    @Li357
    Contributor

    Removing #22557 since I can reproduce on prod and proposal is being worked on here: #21881

  9. mvtglobally commented on Jul 10, 2023

    @mvtglobally

    Regression is completed

    Current PR summary
    #21941 is failing due to #22554
    #22100 is failing due to #21001
    #22188 is failing #22480

  10. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    Thanks @mvtglobally. We're looking into the last blockers. A fix for #22426 is being CP'ed at the moment.

    In the meantime, I checked the ones that were looked into and no longer considered blockers:
    #22487
    #22494
    #22485
    #22480
    #22498

  11. mvtglobally commented on Jul 10, 2023

    @mvtglobally

    @francoisl since checklist is not automatically updated with the new builds any more, can you please tag me once the new CP is ready to test. I dont really have a way to tell

  12. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    Oh true. The fix for #22426 should be live on all platforms on staging, now. The version number will be 1.3.38-5.

    Also, regarding this one:

    #22188 is failing #22480

    Since the issue is only with Gmail accounts, could you run the QA steps again from a private domain please (like a regular applause.expensify.com account)? We found the issue is also happening on production, so we'll treat #22480 as a regular bug.

  13. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    @mvtglobally v1.3.38-6 is also available now, it fixes the blocker #22502.

  14. mvtglobally commented on Jul 10, 2023

    @mvtglobally

    @francoisl CP #22501 is pass

  15. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor
    • Checking off 22502, I tested it on staging

    • A fix for 22445 is being deployed right now, I can also help test when it's fully deployed

    • Checking 22100, tested on staging and can't reproduce the issue
      image

    • Checking 21941, tested on staging - I believe the reported issue is because the email address was so long that the backend didn't accept it. A similar issue is happening on production, so no need to mark this a deploy blocker
      image

    • Checking 22445, fix tested on staging

  16. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    Checklist is complete and all blockers are resolved, waiting for #21651 to be merged and we can ship this.

  17. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    :shipit:

  18. mvtglobally commented on Jul 11, 2023

    @mvtglobally
  19. self-assigned this
    on Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions