Repository navigation
Closed
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.38-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Hook refactor for ValidateLoginPage/index.js #19906
- fix: tweak the anonymous footer component design #20884
- refactor: SelectionListRadio #21048
- [NoQA] Changing the process for making high-traffic accounts #21388
- DMs to show all avatars #21402
- Fix OTP autofill in iOS Safari #21482
- Task description scroll #21553
- [navigation-refactor] Remove getReportIDFromRoute helper function #21702
- Migrate tasks to use
childManagerAccountID#21781 - fix: icon not set when adding bookmark to iOS home screen #21856
- revert usage of InteractionManager in Modal #21865
- Remove remaining uses of
originalMessage.participantsas part of personalDetails migration #21877 - Fix task preview cursor is not pointer #21941
- Update Who Paid section when can modify participants #21945
- Refactor migrate password page to functional component #21960
- Fix massive lag on Task Assignee Selection Modal #22095
- Ios keyboard opens again #22096
- Fix an error message is in English in Spanish account when validate 2nd contact #22100
- Clean up latestDecision conditionals #22141
- fix: 20848 enable 2fa button in verify page #22151
- fix "Android - Keyboard doesn't open automatically while verifying contact method #22164
- Fix: Capitalization in email search causing duplicate email in member invite preview #22168
- Improve Attachment Carousel State Management in AttachmentModal and ReportAttachments #22179
- fix: 'No content to add' error if we send empty alias for email #22182
- fix: emoji modal stops working in the chat when opening in the IOU report #22188
- Migrate ReportActionsView.js to function component #22200
- Fix: 2FA "Disable Authentication" page comes up again if we navigate back to the page in Offline mode #22202
- Fix: Console error appears when opening Workspace Members Page #22203
- fix: workspace members invite page transition #22217
- refactored LoginForm to function component #22224
- Temporarily disable the "Send Money" option #22226
- hide request money option in task report #22244
- UserDetailsTooltip: Pass renderTooltipContentKey to Tooltip #22246
- [NoQA] Update PULL_REQUEST_TEMPLATE.md to hopefully reduce the number of mistakes when pasting the GH Link #22252
- [Fix] Remove dupe code inside reimbursement account page #22253
- [No QA] Fix - Console errors #22254
- Fix: Add Workspace member "Invitation message" page appears when accessing via deeplink #22262
- Remove few instances of
reportAction.actorEmailfor email -> accountID migration #22269 - fix: unwanted linebreaks added when translating html blockquote to markdown #22275
- fix: 22150 main task description updated when subtask is modified #22279
- fix: inconsistency error for zip code and tax ID contains emoji #22280
- fix amount based on currency #22281
- Fix thread time #22285
- Add "use selector" to the PR checklist #22287
- Remove all uses of
actorEmailas part of personalDetails migration (try 2) #22327 - Add Scan receipts Beta #22330
- Hide back button for Not found Page on Report screen #22331
- Fix bank account menu item showing up as disabled in the last step #22346
- Fix
AddWorkspaceRoom's optimistic participant data for non-restricted rooms #22385 - fix "0" display issue after creating task without assignee #22406
- [NO QA] Revert "Release pending versions before submitting a new version for review" #22541
Deploy Blockers:
- [HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed #22398
- [HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Typing feedback text under composer is not being displayed #22426
- [HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] [$1000] Chat - Area outside the group avatar is clickable #22445
- Web - More than 4 Avatars are displayed on the A group chat #22469
- [HOLD for payment 2023-10-05] Report - The request money is broken for "unknown" accounts without login information #22480
- [Hold #22062] Dev: Email Not Displayed in Tooltip on Workspace Members Page #22485
- [$1000] Dev: Web - After deleting a thread message, the message "You" briefly shows up in the LHN before disappearing #22487
- [HOLD for payment 2023-07-26] Dev: Web - Cursor position is not at the end of the task title #22494
- [HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page #22498
- [HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Login - Crash when navigating to the concierge chat via deeplink after login #22502
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Jul 7, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.38-3 🚀
melvin-bot commentedon Jul 7, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Julesssss commentedon Jul 7, 2023
Checking off #22398, after the fix was cherry-picked.
mvtglobally commentedon Jul 10, 2023
Regression is still in progress. We have only 2% left in TR.
Current PR summary
#19906 Pending validation on all platforms
#21482 Pending validation on all platforms
#21781 Pending validation on all platforms
#21877 Pending validation on all platforms
#21941 is failing due to #21941
#21945 Pending validation on all platforms
#22100 is failing due to #21001
#22151 Pending validation on all platforms
#22188 is failing #22480
#22200 Pending validation on all platforms
#22244 Pending validation on all platforms
#22246 Pending validation on all platforms
#22253 Pending validation on all platforms
#22262 Pending validation on all platforms
#22269 Pending validation on all platforms
#22275 Pending validation on all platforms
#22280 Pending validation on all platforms
#22281 Pending validation on all platforms
#22327 Pending validation on all platforms
Julesssss commentedon Jul 10, 2023
@cristipaval I checked off #22469 as you closed it 👍
cristipaval commentedon Jul 10, 2023
Thanks, sorry for missing to check it off here 🙇
mvtglobally commentedon Jul 10, 2023
Regression in TR is completed, down to just a few validations
Current PR summary
#21781 Pending validation on all platforms
#21941 is failing due to #22554
#22100 is failing due to #21001
#22188 is failing #22480
#22253 Pending validation on all platforms
#22275 Pending validation on all platforms
#22327 Pending validation on all platforms
Li357 commentedon Jul 10, 2023
Removing #22557 since I can reproduce on prod and proposal is being worked on here: #21881
mvtglobally commentedon Jul 10, 2023
Regression is completed
Current PR summary
#21941 is failing due to #22554
#22100 is failing due to #21001
#22188 is failing #22480
francoisl commentedon Jul 10, 2023
Thanks @mvtglobally. We're looking into the last blockers. A fix for #22426 is being CP'ed at the moment.
In the meantime, I checked the ones that were looked into and no longer considered blockers:
#22487
#22494
#22485
#22480
#22498
mvtglobally commentedon Jul 10, 2023
@francoisl since checklist is not automatically updated with the new builds any more, can you please tag me once the new CP is ready to test. I dont really have a way to tell
francoisl commentedon Jul 10, 2023
Oh true. The fix for #22426 should be live on all platforms on staging, now. The version number will be 1.3.38-5.
Also, regarding this one:
Since the issue is only with Gmail accounts, could you run the QA steps again from a private domain please (like a regular applause.expensify.com account)? We found the issue is also happening on production, so we'll treat #22480 as a regular bug.
francoisl commentedon Jul 10, 2023
@mvtglobally v1.3.38-6 is also available now, it fixes the blocker #22502.
mvtglobally commentedon Jul 10, 2023
@francoisl CP #22501 is pass
francoisl commentedon Jul 10, 2023
Checking off 22502, I tested it on staging
A fix for 22445 is being deployed right now, I can also help test when it's fully deployed
Checking 22100, tested on staging and can't reproduce the issue

Checking 21941, tested on staging - I believe the reported issue is because the email address was so long that the backend didn't accept it. A similar issue is happening on production, so no need to mark this a deploy blocker

Checking 22445, fix tested on staging
francoisl commentedon Jul 10, 2023
Checklist is complete and all blockers are resolved, waiting for #21651 to be merged and we can ship this.
francoisl commentedon Jul 10, 2023
mvtglobally commentedon Jul 11, 2023
@francoisl is pass #22584