Repository navigation
fix: workspace members invite page transition - #22217
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I have read the CLA Document and I hereby sign the CLA |
|
@b4s36t4 Can you please test using a high traffic account and upload the rest of the screensohts |
|
@s77rt sure will update. |
|
@s77rt With high traffic account this issue seems need an update in code. Afterwards the working can be observed below. |
|
@b4s36t4 Can you explain more here? Was there a problem with sections loading and if so was that related to adding the delay focus? |
|
@s77rt I think the issue relies on loading the contacts. When my account was just a new account adding dealy did worked, but seems delay is a setTimeOut with just 300ms of time. And if you see the old code sections were defined in render function which might be the reason. When I shifted to high traffic account I observed the issue of jitter I think getting sections in render function is the issue so I moved getting sections (contacts) moved out that whenever the transition ends which means modal component is rendered fully then load the sections. |
|
No, it doesn't matter with delay. Delay is only for focusing the input not the whole component. But using |
|
@b4s36t4 Can you attach a video with just the delay fix applied? |
|
@s77rt here it is -> https://user-images.githubusercontent.com/59088937/250649006-8e3bb4ff-7eca-42a9-bc56-2a82f2fee129.webm |
|
@b4s36t4 I meant for a high traffic account |
|
#22217 (comment) this is here. |
|
@b4s36t4 Isn't that video where you applied both the delay focus and moved the |
|
Yes, it is. It has both the changes. |
|
@b4s36t4 Can you attach the video where only the focus delay is applied? (and using a high traffic account) |
|
Yes, understood now. Will share in a minute. |
|
In that last video, is there a vibration of the text? |
|
Yes, it is there. If there's no transition means there's vibration. |
|
I see. In that case please revert the last commit and let's make use of |
|
Ok understood. Will update the PR. |
|
@s77rt I don't think that approach is solving the issue. ai.mp4 |
|
@s77rt also watch this video, this clearly gives the transition and make it more clear this video is the implementation of the current commit (in PR). iu.mp4 |
|
We can't go with this PR as it's. It will cause stale data issue, the sections should be recalculated at every render (or whenever certain data change, this will become easier to handle once we migrate this page to functional component) |
|
It will not, |
|
That's great but can we also use shouldShowOptions? The sections being empty does not look so good. The skeleton view may be better. |
|
Ok, will add that as well. |
|
Final output of the implementation. @s77rt pushed the changes pelase check. |
|
@b4s36t4 Please add the missing screenshots and updates the Tests and QA to:
|
|
@s77rt I don't have a iOS mobile nor the space to accommodate xcode into system, any other way? |
Reviewer Checklist
Screenshots/VideosWebweb.mp4Mobile Web - Chromemweb-chrome.mp4Mobile Web - Safarimweb-safari.mp4Desktopdesktop.mp4iOSios.mp4Androidandroid.mp4 |
|
Thanks @s77rt.!! |
|
Please update the title to reflect the new changes, checkout the rest of unchecked boxes. You need to test on iOS it's mandatory, I see this is your first PR so I think it's okay to ignore for this one. But please next time before you submit a proposal have all the OS requirements for tests |
|
Thanks so much @s77rt, installing xcode now. Updated the title and checked all the boxes as well. |
|
Please check the checklist again, it does not look to have the correct format (in "I added steps for the expected offline behavior in the Offline steps section") |
|
Reassigning @mountiny here as reviewer, since he was assigned originally in the linked issue |
mountiny
left a comment
There was a problem hiding this comment.
Thanks everyone!
@b4s36t4 congrats on your first pr!
Please going forwards always link issues with a full link in the PR body: $ https://github.com/Expensify/App/pull/22217 for example so the automation works correctly thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|



Details
Workspace invite member page is flickering and doesn't have the transition included in it which is caused by input focusing while rendering.
Fixed Issues
$ #22036
PROPOSAL: #22036 (comment)
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
aa.webm
Mobile Web - Chrome
telegram-cloud-document-5-6138761447246662019.mp4
Mobile Web - Safari
Desktop
https://github.com/Expensify/App/assets/59088937/9b7084b1-26d0-4351-a70e-56858dd7b8aaiOS
Android
iooo.mp4