Repository navigation
Fix AddWorkspaceRoom's optimistic participant data for non-restricted rooms - #22385
Conversation
52d8d03 to
8a468b5
Compare
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-07.at.4.17.45.AM.movMobile Web - ChromeScreen.Recording.2023-07-07.at.4.43.34.AM.movMobile Web - SafariRPReplay_Final1688685695.MP4DesktopScreen.Recording.2023-07-07.at.4.24.05.AM.moviOSAndroidANDROID_t.mov |
|
@francoisl In the restricted room, an extra hidden profile is shown for me while offline is this expected? Screen.Recording.2023-07-07.at.4.17.45.AM.mov |
|
Hmm weird. What happens if you create room while being online instead? Also can you see the same thing from |
|
Here is the online recording you can see the count reduced from 3 to 2 on the Details page. Screen.Recording.2023-07-07.at.4.26.09.AM.mov |
|
Yes happens on the main too! |
|
Ok thanks. The |
|
Discussed the |
Santhosh-Sellavel
left a comment
There was a problem hiding this comment.
LGTM, thanks!
|
@pecanoro - Puneet already approved and I imagine you're out for the day as well, going to self-merge since it's for a blocker. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|
| // The participants include the current user (admin) and the employees. Participants must not be empty. | ||
| const participants = _.unique([currentUserAccountID, ...policyMembers]); | ||
| // The participants include the current user (admin), and for restricted rooms, the policy members. Participants must not be empty. | ||
| const members = visibility === CONST.REPORT.VISIBILITY.RESTRICTED ? policyMembers : []; |
There was a problem hiding this comment.
This should have been updated to only add the owner as a member when we added functionality for a member to be able to join the room. This was fixed in #31375
Details
When creating a public room while offline, make sure we only use optimistic the current user's account ID for the optimistic data, so that we don't accidentally show the workspace members' details.
This implements @kushu7's proposal, but I'm submitting a PR for it since they're offline at the moment and
Fixed Issues
$ #22353
PROPOSAL: #22353 (comment)
Assigning @puneetlath as discussed 1:1, because he's already familiar with these changes.
Tests
+floating button > New RoomOffline tests
The test/QA steps should be taken while offline
QA Steps
Same as test steps above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android