Repository navigation
Fix: Add Workspace member "Invitation message" page appears when accessing via deeplink - #22262
Merged
Merged
Conversation
6 tasks done
Member
Reviewer Checklist
Screenshots/VideosWebweb.mp4Mobile Web - Chromemweb-chrome.mp4Mobile Web - Safarimweb-safari.mp4Desktopdesktop.mp4iOSios.mp4Androidandroid.mp4 |
s77rt
suggested changes
Jul 5, 2023
|
|
||
| componentDidMount() { | ||
| if (_.isEmpty(this.props.invitedEmailsToAccountIDsDraft)) { | ||
| Navigation.goBack(ROUTES.getWorkspaceInviteRoute(this.props.route.params.policyID), true); |
s77rt
suggested changes
Jul 5, 2023
Comment on lines
+84
to
+85
| if (_.isEmpty(this.props.invitedEmailsToAccountIDsDraft)) { | ||
| Navigation.goBack(ROUTES.getWorkspaceInviteRoute(this.props.route.params.policyID), true); | ||
| return Navigation.goBack(ROUTES.getWorkspaceInviteRoute(this.props.route.params.policyID), true); |
Member
There was a problem hiding this comment.
I meant
Navigation.goBack(...);
return;Not much difference I guess but that looks more readable and it's clearer that we are doing this for an early return situation
marcaaron
approved these changes
Jul 5, 2023
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
64 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.38-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Navigate user to the invite members page when they try to access directly invite message page by the link/deeplink without selecting any members.
Fixed Issues
$ #21412
PROPOSAL: #21412 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-07-05.at.5.43.05.PM.mov
Mobile Web - Chrome
avc.webm
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-05.at.17.48.11.mp4
Desktop
Screen.Recording.2023-07-05.at.5.53.44.PM.mov
iOS
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-05.at.17.52.12.mp4
Android
av.webm