Repository navigation
Add conditional wallet terms based on program ID - #28433
Conversation
luacmartins
left a comment
There was a problem hiding this comment.
Code LGTM. Just one small comment.
| <Text style={styles.mb5}>{Localize.translateLocal('termsStep.shortTermsForm.expensifyPaymentsAccount')}</Text> | ||
| <Text style={styles.mb5}> | ||
| {Localize.translateLocal('termsStep.shortTermsForm.expensifyPaymentsAccount', { | ||
| walletProgram: props.userWallet.walletProgramID === CONST.WALLET.MTL_WALLET_PROGRAM_ID ? 'Expensify Payments' : 'The Bancorp Bank', |
There was a problem hiding this comment.
I think we should create consts for Expensify Payments and The Bancorp Bank
Reviewer Checklist
Screenshots/VideosN/A copy changes WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Add conditional wallet terms based on program ID (cherry picked from commit bcc8a63)
…g-28433-1 🍒 Cherry pick PR #28433 to staging 🍒
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.75-1 🚀
|
|
@coleaeason Are you going to QA this one as per this ? |
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
@MariaHCD @luacmartins Please review. This conditionally shows the correct terms to the user based on the wallet's program ID. Requires https://github.com/Expensify/Web-Expensify/pull/39029 for testing.
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/321227
PROPOSAL:
n/a
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android