Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.75-12
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Blur Magic Code input when click outside #24012
- Fix: Wrong currency in request money page after login #25786
- Allow Editing Distance Requests #26141
- Implement dedicated route for CountryPicker in AddressPage #26742
- Use initialValue in withOnyx and other optimizations for ReportScreen #26772
- [TS migration] Migrate 'EmojiPickerAction.js' lib to TypeScript #26795
- create the Expensify card page #26915
- Fix Sign in- Language preference doesn't persist when user Signs in with google #26948
- Fix: 26339 Workspace - Unable to remove error reported member #26975
- map not loading when online #26998
- [No QA] [TS Migration] Transaction lib #27138
- Bump reanimated to 3.5.4 #27193
- migrate PopoverReportActionContextMenu class to function component #27221
- fix(selection-list): highlight on lists with 1 section #27246
- Notifications for editing money requests #27299
- [NoQA] [TS migration] Migrate 'CloseAccount.js' lib to TypeScript #27355
- Fix money request header avatar border color does not match header background color #27413
- chore: migrate withKeyaboardState class to function component #27415
- RequestorStep.js: class to functional component refactor #27455
- Fix suggestion menu closes on typing @ at second line #27490
- [No QA] [TS migration] Migrate 'RenameExpensifyNewsStatus.js' lib to TypeScript #27501
- [TS migration] Migrate 'getPlaidLinkTokenParameters' lib to TypeScript #27527
- [No QA][TS migration] Migrate 'getOSAndName' lib to TypeScript #27534
- [No QA][TS migration] Migrate 'ErrorUtils.js' lib to TypeScript #27659
- Fix/26669 lhn logic for paid reports #27700
- Display smartscan errors BELOW the field #27735
- Prevent nested timezone setting #27745
- Move all header buttons to overflow menu #27748
- Fix: Chat - Loader is shown on top of image even after image is loaded in attachment carousel #27751
- fix: 27252 Profile pic gets removed in offline mode #27757
- [No QA] [TS migration] Migrate 'Chronos.js' lib to TypeScript #27770
- fix: prevent transparent suggestion list by using portal #27771
- [No QA] [TS migration] Migrate 'PusherConnectionManager.js' lib to TypeScript #27781
- [TS migration] Migrate 'ReceiptUtils.js' lib to TypeScript #27794
- Fix/27586: Extra spaces between text is not displayed #27822
- Fix/27383: Prevent request money if empty waypoint #27826
- Update Task Report System Messages and LHN Display for Consistency #27827
- Fix 25% opacity in MoneyRequestView and TaskView #27830
- Fixing incorrect message timing display when changing timezones #27838
- Docs: 404 page #27839
- [No QA] [TS migration] Migrate 'ValidationUtils.js' lib to TypeScript #27846
- [No QA] [TS migration] Migrate 'Accessibility' lib to TypeScript #27847
- Fix stacked avatar is transparent when long press on Android #27850
- [No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865
- Feat: Editable billable flag #27875
- Fix Copying Sent Money Report Action text copies a wrong text #27889
- Fix: Receipt scan request container corners are not rounded while it is in progress #27900
- Edit the route of new task page #27909
- Add billable field to Transaction #27910
- Fix duplicate participant name and avatar #27912
- fix: Web - green dot appears even if task is deleted #27915
- App displays waypoint address page briefly on click on Go back to… #27917
- refactor: migrated WalletStatementModal to function component #27934
- Fix: Transition animation does not work for request money page #27947
- #26793: Edit a tag in a money request #27950
- use vertical padding for signInIconButton #27953
- Fix map view attribution text is not visible on hover #27954
- [NoQA] Fix test to prepare for onyx update #27958
- remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace #27983
- fix: Emoji suggestions is not displayed between '~~' & '__'. #27984
- Fix Save button is not at the bottom of the page #27987
- [HelpDot] Add styling for home page and hub page #27988
- The scale control is hidden on the map #28003
- fix error for zip code in bank account step #28043
- update spilt regex to fix suggestions issue #28045
- Fix 26829 after logout unsubscribe keyboardshortcut's documented shortcuts #28053
- [HelpDot] Show a section's articles in new page #28100
- [No QA]Fix E2E Performance Regression Tests #28109
- bump expensify-common version to exclude double quote from url #28113
- fix new tab opens when downloading offline #28114
- chore: revert pull 27369 changes #28117
- Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120
- Status UI fixes #28122
- added browser check for setting line height #28126
- 23672-Fixing last word text disappearance on quote messages with links in android #28127
- fix: prevent tab swipe glitches when attempting to select text on the Scan tab #28135
- Fixed inconsistent back button behavior of NewChatSelectorPage #28138
- #26793: show selected tag even if all are disabled #28151
- fix: sync draft and edit status of thread first chat #28154
- Fix: App crashes when report ID is wrong bacause of the policy #28199
- Revert "Fix/27383: Prevent request money if empty waypoint" #28208
- fix: state gets cleared when selecting the same country #28220
- [Can only be tested after deployed to Staging/Production] Add
/get-assistance/*url to show Smart App Banner #28222 - Create Create-A-Report.md #28223
- [No QA] Improve formatting of routes file #28224
- add useFocus prop missing #28226
- Create Applying Tax to Expenses.md #28227
- Revert PR 27340 #28229
- Create Upload-Receipts for Help site.md #28230
- Ctreate Merge-Expenses.md for Help Site #28233
- Update Create-Expenses.md in Expensify Help #28235
- remove sms domain task preview #28243
- remove PressableWithFeedback wrap button choose file and give permission #28245
- fix: can edit private note of archived workspace using URL #28252
- Add Scrollview to page #28270
- Update Reimbursements.md #28286
- Adding call to clear key onyxUpdatesFromServer #28290
- Fix distance request next button while offline #28292
- Fix horizontal padding for lounge access #28293
- Update and rename Tax.md to Tax Tracking.md #28298
- Bump onyx #28299
- Update User-Roles.md #28300
- [No QA] Revert "Prevent nested timezone setting" #28307
- fixed getCommonSuffixLength compare value #28310
- fix console error on MenuItem #28314
- Fix crash when open currency selector page #28319
- Prevent nested timezone setting #28355
- Update Rippling.md and Greenhouse.md #28356
- [CP Staging] fix crash on room name validation #28366
- [NoQA] Add missing comma at the end of the line to fix lint #28367
- Update Merge-Expenses.md #28369
- Add conditional wallet terms based on program ID #28433
- [CP Staging] Fix race condition in onyx to stop app crashing when opening a new thread #28440
- [CP Staging] fix: regression 28417 #28458
- [CP Staging] fix composer focus after deleting a message from edit mode #28462
- [CP Staging] Fix notification navigation to report #28525
- [CP Staging] fix: use correct variables for navigateToNextPage fn #28527
- [CP-Staging]:fix crash while opening emoji picker #28558
- [CP Staging] prevent OpenReport api call with "null" report #28560
- [CP Staging] Fixes not found page not being shown properly when not having access to report #28584
- [CP Staging] Revert "Blur Magic Code input when click outside" #28611
- [CP Staging] fix cursor moving to new line when tapped return #28613
Deploy Blockers:
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money #28417
- Task - App crashes when assigning task #28418
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] Chat - App crashes when replying to message in thread #28419
- [HOLD for payment 2023-10-28] [$500] Chat - Focus is lost after deleting a message from edit mode #28420
- [HOLD for payment 2023-10-10] 3 dot menu - "Mark as Done" appears both as a button and in the 3 dot menu #28421
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] Room - App crashes when typing room name during room creation #28463
- [HOLD for payment 2023-10-18] [$500] Chat - No loading animation when scrolling through chat history offline #28466
- BA - App crashes after filling out forms offline and select 'Continue with setup' #28467
- [$250] Web - Room - Тransfer from room to workspace modal stuck for a moment #28468
- [$250] Profile-Timezone title is selected when user selects the text #28471
- Send Message - App crashes when User creates new chat #28473
- [$500] IOU-Editing distance request, new message is not shown but for request money, new message shown #28478
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] Chat - Deeplinks - Skeleton is shown instead "You don’t have access" page #28489
- Web - Wallet Statement Modal - Statement is not displayed and errors appear #28490
- iOS - SMS - Code is changed when select it in autofill #28494
- [HOLD 2023-10-16] [$125] mweb/Safari - Composer - Cursor does not moved to a new line in the composer when tapped on the "return" #28501
- [HOLD for payment 2023-10-10] [$250] App crashing when clicked send message from Fub menu quickly after sign in from google #28504
- [HOLD for payment 2023-10-10] [$125] Task - When the receiver clicks on a task, "Hmm... it's not here" is displayed briefly #28508
- Desktop- IOU - Notification is only received for the first edit of IOU request in workspace #28520
- [HOLD for payment 2023-10-25] Chat - Pasted text reflects Full Display name #28521
- [$500] Android - Thread - Back button is not responsive in the parent report after leaving thread #28522
- Request money - A blank page blinks when transitioning between Request money pages #28523
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android - Scan IOU - Error shows up when tapping on Capture button to take a photo #28526
- [HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538
- [HOLD for payment 2024-04-05] [$500] mWeb - Cursor jumps back to the start when adding an emoji in edit #28563
- [$500] Profile - Contact method - App does not refocus to magic code on canceling contact method remove #28590
- [HOLD 28358][$500] Edited currency Changes back to the previous currency #28605
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Assign task - Assign task tooltip is not displaying email and avatar #28626
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Sep 28, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.75-0 🚀
kavimuru commentedon Sep 29, 2023
Regression 38% progress in the TR. We are working on the PRs.
kavimuru commentedon Sep 29, 2023
@chiragsalian Regression TR is in 82% progress. We are still validating PRs
#27826 failing with #27383 (not fixed)
#27830 failing with #25683 (comment) and #28464 and happening in production checking if off
#27947 failing with #28417
kavimuru commentedon Sep 29, 2023
Regression TR is completed. We just have 2 PRs to be validated.
#27826 failing with #27383 (not fixed)
#27830 failing with #25683 (comment) and #28464 and happening in production checking if off
#27947, #28126, #27947 failing with #28417
#28243 failing with #28418
#28226 failing with #28463
#27735 failing with #28498
#27748 failing with #28421
#27875 failing with #28516
#27934 failing with #28490
#28154 failing in android with #28419
kavimuru commentedon Sep 29, 2023
#27826 failing with #27383 (not fixed)
#27830 failing with #25683 (comment) and #28464 and happening in production checking if off
#27947,#28126, #27947 failing with #28417
#28243 failing with #28418
#28226 failing with #28463
#27735 failing with #28498
#27748 failing with #28421 and #28522
#27875 failing with #28516
#27934 failing with #28490
#28154 failing in android with #28419
#28151 and #27950 failing with #28069. Can we check it off if it is still behind beta?
#27299 failing with #28520
#27889 failing with #28521
#28433 as per this Coleaeson will validate https://github.com/Expensify/Web-Expensify/pull/39029
mvtglobally commentedon Sep 29, 2023
@chiragsalian TR regression is completed
Still repro on the latest build 1.3.75-2 blockers cc @mountiny
#28328
#28417
#28463
#28468
#28471
#28478
#28489
#28490
#28494
#28504
#28508
#28520
#28521
#28522
#28523
#28526
Unchecked PRs
#27826 failing with #27383 (not fixed)
#27830 failing with #25683 (comment) and #28464 and happening in production checking if off
#27947,#28126, #27947 failing with #28417
#28243 failing with #28418
#28226 failing with #28463
#27735 failing with #28498
#27748 failing with #28421 and #28522
#27875 failing with #28516
#27934 failing with #28490
#28154 failing in android with #28419
#28151 and #27950 failing with #28069. Can we check it off if it is still behind beta?
#27299 failing with #28520
#27889 failing with #28521
#28433 as per this Coleaeson will validate Expensify/Web-Expensify#39029
mountiny commentedon Oct 1, 2023
Checking #27889 off as its new feature and we just need to update one case
mountiny commentedon Oct 1, 2023
Checked off resolved deploy blockers and couple of blockers got remoted
mountiny commentedon Oct 2, 2023
Checking
Blockers:
mountiny commentedon Oct 2, 2023
mountiny commentedon Oct 2, 2023
mountiny commentedon Oct 2, 2023
#28563 is resolved in staging too
mountiny commentedon Oct 2, 2023
Only new crashes already been resolved as part of the deploy blocker fixes
Graphs looking good too
mountiny commentedon Oct 2, 2023
Confirmed last deploy blocker is fixed in staging #28504
mountiny commentedon Oct 2, 2023