Repository navigation
Update Payments Page to show wallet balance, empty state, and more! - #3890
Conversation
…s-finishPaymentsPage 52.74.223.119 ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==
There was a problem hiding this comment.
Besides a super minor change and a quick question, the code looks great and tests well, good stuff :)
I'm wondering whether we should display a loader for the entire modal or disable the "Add Payment Method" button while we're waiting to grab the user's payment methods. Otherwise, it can cause the (kinda ugly/confusing) scenario depicted here where the user opens the dropdown but then the anchor for the dropdown moves:
2021-07-07_12-59-42.mp4
|
@stitesExpensify Were you able to look into that issue I mentioned above? |
|
Hey there! Sorry for not updating you, but I'm adding a loading circle as we speak :) |
|
Hey @stitesExpensify, no worries! I just tested out your solution and it doesn't really seem like it fixes the problem I brought up earlier? I think we should just disable the "Add Payment Method" button until everything is loaded: 2021-07-10_09-30-59.mp4@Expensify/design What are your thoughts? |
|
Ah, I see. That makes sense to me. I think we could just "disable" the Add Payment row and make it like 50% opacity like we do with disabled buttons. Thoughts on something like that? |
Yup! I totally agree, that was my original recommendation. Should be a one-liner too. |
|
Updated to disable the input when loading :) |
|
Hey @stitesExpensify sorry for the delay! |
There was a problem hiding this comment.
@stitesExpensify Looks good! Let's also get rid of the smaller loading spinner you added since it seems kinda redundant now?
I disagree, I think that showing when the methods are loading is still a useful UI element. A disabled button doesn't show that things are loading in and of itself. I think the loader should stay |
…s-finishPaymentsPage
|
@stitesExpensify Sorry for the late response; I've been traveling back to LA. I know this PR is really simple and it's definitely been ongoing for a long time, so sorry for that as well! I still don't really understand why we need both loaders still. Correct me if I'm wrong, but it looks like both loaders should disappear simultaneously once Also, from a pure UX standpoint, I think we should get someone from @Expensify/design to help us decide on how it looks. Personally, I think there should only be one loader for everything on the page. Here's the screen recording (with both loaders) for reference: |
|
Candidly I'm a little lost on what is going on here, but looking at the video that Jasper just posted, I agree that the two loading spinners feel strange. Could we just have one that loads everything? |
|
🤦 You're right. Totally my bad, sorry. I forgot that the wallet balance also has a loader. I think we should just keep the balance loader and get rid of the smaller one. Sound good @shawnborton ? |
|
Sounds good! |
|
Sorry again about that @jasperhuangg. Updated! |
jasperhuangg
left a comment
There was a problem hiding this comment.
Looks great! Thanks for your patience with the review :)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.79-5🚀
|
|
🚀 Deployed to production in version: 1.0.80-2🚀
|

Details
This PR improves the Payments page and brings it more in line with the original design.
Specifically:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/169463
Tests / QA
Tested On
Screenshots