Repository navigation
show delegate no access modal while deleting a contact - #59978
Merged
JS00001 merged 3 commits intoApr 14, 2025
Merged
Conversation
JS00001
self-requested a review
April 10, 2025 11:30
JS00001
previously approved these changes
Apr 10, 2025
Contributor
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari59978-web-chrome-001.mp4MacOS: Desktop59978-desktop-001.mp4Android: Native59978-android-hybrid.mp4Android: mWeb Chrome59978-mweb-chrome-001.mp4iOS: Native59978-ios-hybrid-001.mp4iOS: mWeb Safari59978-mweb-safari-001.mp4 |
rojiphil
reviewed
Apr 10, 2025
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
@allgandalf Thanks for the PR.
Did you miss adding screenshots/videos?
Also, unit tests are failing because of our PR. Let’s fix it.
Otherwise, the changes works well.
Contributor
Author
|
JS00001
approved these changes
Apr 14, 2025
rojiphil
approved these changes
Apr 14, 2025
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
Thanks @allgandalf for the updated PR.
@JS00001 LGTM. And looks like only the merge is left here.
All yours now. Thanks.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.28-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #59093
PROPOSAL: #59093 (comment)
Tests
Same as QA
Offline tests
Same as QA
You would need to already be copiloted though before going offline
QA Steps
Precondition:
Test:
Verify that we see a modal explaining that these actions cannot be performed by a delegate like we do when adding a contact method
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-04-14.at.6.40.25.PM.mov
MacOS: Desktop