Skip to content

Deploy Checklist: New Expensify 2025-04-15 #60222

Closed

Description

@github-actions

Release Version: 9.1.28-15
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on Apr 15, 2025
  2. github-actions commented on Apr 15, 2025

    @github-actions
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.28-1 🚀

  3. mountiny commented on Apr 15, 2025

    @mountiny
    Contributor

    @rezkiy37 will QA the #60110 PR across the cherry pics, no need to hold the deploy though

  4. mjasikowski commented on Apr 15, 2025

    @mjasikowski
    Contributor

    #60246 demoted

  5. izarutskaya commented on Apr 15, 2025

    @izarutskaya
  6. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. mvtglobally commented on Apr 15, 2025

    @mvtglobally

    Regression is completed.

    Blockers:
    #60223
    #60225
    #60226
    #60228
    #60229
    #60232
    #60233
    #60234
    #60238
    #60239
    #60240
    #60250
    #60251
    #60252
    #60254
    #60255
    #60256
    #60260
    #60271
    #60276
    #60280
    #60281
    #60283
    #60295
    #60299
    #60301

    PRs
    #56068 Issues found when executing #60241 & #60243. Blockers removed. Checking off
    #57281 issue found #60266. Repro in PROD, checking off
    #57643 (comment) - Blocked. Can you pls check?
    #58597 - multiple blocker issues referencing this PR. Pls double check if ok to check it off
    #59300 - This PR is failing for Android because of the original issue. repro in PROD, checking off
    #59835 - Pending validation on Native apps
    #59966 - Pending validation on Native apps, and failing
    #59977 - Is failing with #60283 doulbe check if related
    #59993 - Pending validation on Native apps, mWeb and Desktop
    #59995 - Pending validation on Native apps & Desktop
    #60034 - This PR is failing because of issue #60281
    #60075 - checking off #60075 (comment)
    #60128 - - Pending validation on Native apps, mWeb and Desktop
    Checking CPs

  8. marcaaron commented on Apr 15, 2025

    @marcaaron
    Contributor

    Checking off #60239 since it's a new feature and minor issue

  9. luacmartins commented on Apr 15, 2025

    @luacmartins
    Contributor
  10. marcaaron commented on Apr 15, 2025

    @marcaaron
    Contributor

    Checked off #60255 because the expected behavior is not correct on staging or prod builds.

  11. marcaaron commented on Apr 15, 2025

    @marcaaron
    Contributor

    I demoted #60283 because it appears to be related to the Create Report flow which is behind a beta.

  12. carlosmiceli commented on Apr 15, 2025

    @carlosmiceli
    Contributor

    Checked off #60280

  13. mvtglobally commented on Apr 16, 2025

    @mvtglobally

    Checked off multiple CPs

  14. mvtglobally commented on Apr 16, 2025

    @mvtglobally

    We validated CP on Web #60298 (comment) but dont have enough locked phones to run all platforms. Can you pls also check internally

  15. mvtglobally commented on Apr 16, 2025

    @mvtglobally

    Latest summary

    Regression completed

    Blockers:
    #60223
    #60225
    #60226
    #60240
    #60250
    #60256 - is closed, ok to check off?
    #60260

    PRs
    #57643 (comment) - Blocked. Can you pls check?
    #58597 - multiple blocker issues referencing this PR. Pls double check if ok to check it off
    #59966 - Pending validation on Native apps due to limited phone numbers. Are we ok to check this off? #59966 (comment)
    #59977 - Is failing with #60283. Blocker label removed, so checking off
    #59995 - is failing with #59348. Checking off
    #60034 - This PR is failing because of issue #60281. Issue closed. Checking off
    #60128 - failing with #60339. repro in PROD. checking off
    #60298 - Can we check off based on 1 validation? #60298 (comment)

  16. youssef-lr commented on Apr 16, 2025

    @youssef-lr
    Contributor

    Checking off #60260 as it's buggy in production too, I'll keep investigating it in the meantime.

  17. marcaaron commented on Apr 16, 2025

    @marcaaron
    Contributor

    There's some GH status event happening related to Co-pilot but I think it should be safe to deploy.

  18. marcaaron commented on Apr 16, 2025

    @marcaaron
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions