Repository navigation
[CP Staging] Fix ExpensifyApproved illustration display in the light mode - #60242
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
It was a regression caused by a PR I've reviewed, so I am taking care of checklist here |
Reviewer Checklist
Screenshots/Videos |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…0226-illustration-color [CP Staging] Fix ExpensifyApproved illustration display in the light mode (cherry picked from commit 6d6628c) (CP triggered by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.28-11 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.1.28-14 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|












Explanation of Change
Fix ExpensifyApproved illustration display in the light mode
Fixed Issues
$ #60226
PROPOSAL: N/A
Tests
Precondition:
ExpensifyApproved!illustration displayes in correct colors.Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in the Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop