Skip to content

fix: Thread-Infinite Loading Occurs When Replying to a Deleted Parent Message - #61635

Closed
djordjemitrovic00 wants to merge 7 commits into
Expensify:mainfrom
djordjemitrovic00:chat-thread-skeleton
Closed

djordjemitrovic00 wants to merge 7 commits into
Expensify:mainfrom
djordjemitrovic00:chat-thread-skeleton

Conversation

@djordjemitrovic00

@djordjemitrovic00 djordjemitrovic00 commented May 8, 2025 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Previously, we only checked whether the isDeletedParentAction flag was set to true to determine if a chat thread was deleted. However, we should introduce a utility function called isChatThreadDeleted in ReportUtils.ts that also checks whether the deleted property is null. If deleted is not null, we can treat the thread as deleted.
In the sidebar, "Deleted message" needs to be displayed instead of "Hidden" or empty message. In SidebarUtils.ts, this is handled through the reportName variable, which uses the getReportName function that now relies on our new isChatThreadDeleted function.

We can invoke the getReportAction function, providing report.parentReportActionID as the report action ID to retrieve the parent report action. From the parent report action, we can then extract the message and check for the presence of the deleted or isDeletedParentAction flags.

Additionally, when sending a message to a deleted thread, both the deleted and isDeletedParentAction flags may be missing from the message itself. Nevertheless, these flags are still available within reportAction.originalMessage. Consequently, we have also implemented a check for their presence in the originalMessage.

There is a useful function, IsDeletedMessage, located in ReportActionUtils.ts. By modifying it to check both the deleted and isDeletedParentAction flags on both the message and the originalMessage, we can reliably determine whether a message has actually been deleted. We can then reuse this improved function within the new isChatThreadDeleted function.

Furthermore, because a sent message is displayed as edited rather than deleted, we must adjust the way we retrieve message fragments. Specifically, a deleted chat thread scenario is identified when there is only a single message present in the message property. Therefore, an additional check for this condition has been incorporated when retrieving chat fragments within the getReportActionMessageFragments function.

With this approach, the HeaderView.tsx component will correctly display the title "Deleted message" instead of showing a loading skeleton.

Fixed Issues

$ #59392
$ PROPOSAL: #59392 (comment)

Tests

I checked tests that are related to those enhancements, and no tests were failing.

Created new unit tests for functions I changed. There was no tests for function IsMessageDeleted so I added tests for whole function.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
We need 2 application instances and 2 users to test this.
User A initiate a new chat, and provide User B’s email address.
Send a message to User B in the direct conversation.
Sign in with User B to access the message thread.
Return to User A, locate the sent message, right-click on it, remove it.
Switch back to User B and post a reply in the same thread.
Observe the following issues:

  • The thread header gets stuck in a perpetual loading state. (Shouldn't happen)

  • The message appears to have been edited rather than deleted. (Should be deleted)

  • In the sidebar, the conversation is marked as “Hidden” instead of showing as a “Deleted” message. (should be deleted)

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • [ x I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.app.mp4
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
ios.app.mp4
iOS: mWeb Safari
ios.chrome.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.app.mp4

@djordjemitrovic00
djordjemitrovic00 requested a review from a team as a code owner May 8, 2025 01:25
@melvin-bot
melvin-bot Bot requested review from shubham1206agra and removed request for a team May 8, 2025 01:25
@melvin-bot

melvin-bot Bot commented May 8, 2025

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented May 8, 2025 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@djordjemitrovic00 djordjemitrovic00 changed the title Chat thread skeleton fix: Thread-Infinite Loading Occurs When Replying to a Deleted Parent Message May 8, 2025
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request May 8, 2025
@shubham1206agra

Copy link
Copy Markdown
Contributor

@djordjemitrovic00 Please write the tests properly

@shubham1206agra

Copy link
Copy Markdown
Contributor

And please upload videos properly

@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey, thanks for guidelines :)

@djordjemitrovic00 Please write the tests properly

I've just changed them following how other tests are written. I hope they are good now, but can you be a little bit more specific if they are not good enough? Or point me to some guidelines on how you write tests here?

And please upload videos properly

Fixed, seems like no space before and after link doesnt embed it as video.

@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey @shubham1206agra Can you please take a look and give me some feedback? Or any update if we are waiting for something? Thanks in advance

@francoisl

Copy link
Copy Markdown
Contributor

Can you please pull main in your branch, it's running very far behind now. Also double-check the author checklist please, at least one checkbox was updated incorrectly
image

@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey @francoisl Thanks for reaching out

I created new PR with fresh changes, because after merging with main there was leftover unsigned commit which I cant amend without rebasing all commits. You can take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants