Skip to content

fix: Thread-Infinite Loading Occurs When Replying to a Deleted Parent Message - #62245

Merged
francoisl merged 7 commits into
Expensify:mainfrom
djordjemitrovic00:chat-thread-skeleton-new
Jun 18, 2025
Merged

francoisl merged 7 commits into
Expensify:mainfrom
djordjemitrovic00:chat-thread-skeleton-new

Conversation

@djordjemitrovic00

Copy link
Copy Markdown
Contributor

Explanation of Change

Previously, we only checked whether the isDeletedParentAction flag was set to true to determine if a chat thread was deleted. However, we should introduce a utility function called isChatThreadDeleted in ReportUtils.ts that also checks whether the deleted property is null. If deleted is not null, we can treat the thread as deleted.
In the sidebar, "Deleted message" needs to be displayed instead of "Hidden" or empty message. In SidebarUtils.ts, this is handled through the reportName variable, which uses the getReportName function that now relies on our new isChatThreadDeleted function.

We can invoke the getReportAction function, providing report.parentReportActionID as the report action ID to retrieve the parent report action. From the parent report action, we can then extract the message and check for the presence of the deleted or isDeletedParentAction flags.

Additionally, when sending a message to a deleted thread, both the deleted and isDeletedParentAction flags may be missing from the message itself. Nevertheless, these flags are still available within reportAction.originalMessage. Consequently, we have also implemented a check for their presence in the originalMessage.

There is a useful function, IsDeletedMessage, located in ReportActionUtils.ts. By modifying it to check both the deleted and isDeletedParentAction flags on both the message and the originalMessage, we can reliably determine whether a message has actually been deleted. We can then reuse this improved function within the new isChatThreadDeleted function.

Furthermore, because a sent message is displayed as edited rather than deleted, we must adjust the way we retrieve message fragments. Specifically, a deleted chat thread scenario is identified when there is only a single message present in the message property. Therefore, an additional check for this condition has been incorporated when retrieving chat fragments within the getReportActionMessageFragments function.

With this approach, the HeaderView.tsx component will correctly display the title "Deleted message" instead of showing a loading skeleton.

Fixed Issues

$ #59392
$ PROPOSAL: #59392 (comment)

Tests

I checked tests that are related to those enhancements, and no tests were failing.

Created new unit tests for functions I changed. There was no tests for function IsMessageDeleted so I added tests for whole function.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
We need 2 application instances and 2 users to test this.
User A initiate a new chat, and provide User B’s email address.
Send a message to User B in the direct conversation.
Sign in with User B to access the message thread.
Return to User A, locate the sent message, right-click on it, remove it.
Switch back to User B and post a reply in the same thread.
Observe the following issues:

  • The thread header gets stuck in a perpetual loading state. (Shouldn't happen)

  • The message appears to have been edited rather than deleted. (Should be deleted)

  • In the sidebar, the conversation is marked as “Hidden” instead of showing as a “Deleted” message. (should be deleted)

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.app.mp4
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
ios.app.mp4
iOS: mWeb Safari
ios.chrome.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.app.mp4

@djordjemitrovic00
djordjemitrovic00 requested a review from a team as a code owner May 17, 2025 08:07
@melvin-bot
melvin-bot Bot requested review from shubham1206agra and removed request for a team May 17, 2025 08:07
@melvin-bot

melvin-bot Bot commented May 17, 2025

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@djordjemitrovic00 djordjemitrovic00 changed the title New branch fix: Thread-Infinite Loading Occurs When Replying to a Deleted Parent Message May 17, 2025
@djordjemitrovic00
djordjemitrovic00 force-pushed the chat-thread-skeleton-new branch from e76e66d to d30865b Compare May 19, 2025 23:12
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hi @francoisl
I believe I’ve resolved all the test issues now. However, the lint-changed and performance checks might still fail since I don’t have permission to approve workflows on my first pull request. If they fail again when you approve, I’ll do my best to pull from main again as soon as I get the email notification that you attempted an approval, so hopefully, you’ll be able to quickly re-approve. Thanks in advance

@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hi @shubham1206agra Can you give me some feedback related to PR? Seems like all checks passed

Comment thread src/libs/ReportActionsUtils.ts Outdated
Comment on lines 1154 to 1117

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djordjemitrovic00 I believe isDeletedParentAction condition should be used first, then the additional condition.

@djordjemitrovic00 djordjemitrovic00 Jun 3, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this comment is fixed and I answered to another one you posted, can you check? @shubham1206agra

Comment thread src/libs/ReportActionsUtils.ts Outdated
Comment on lines 1605 to 1816

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djordjemitrovic00 Can you explain why do we need that?

@djordjemitrovic00 djordjemitrovic00 Jun 3, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is used to display first message on thread and if we don't have any replies, it will show the message as "edited" instead of deleted message

If we dont do this, it will display latest message as blank message - no text at all with included (edited) flag, because "text" property gets blank after message is deleted. NOTE: This only occurs if we try to reply to thread, which gets deleted by the way and no text has been sent.

This way we won't show it blank, but we will check if original message has "deleted" flag and if it has (and IsDeletedParentAction is initially false) then it will mark it as deleted and show "Deleted Message" instead

@djordjemitrovic00
djordjemitrovic00 force-pushed the chat-thread-skeleton-new branch 4 times, most recently from 3f9fa8e to 05adca3 Compare June 3, 2025 09:41
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

@shubham1206agra @francoisl Can you, please, review this? No answer or update from you for a whole week, can you please provide me informations on what are we waiting for?

@shubham1206agra

Copy link
Copy Markdown
Contributor

@djordjemitrovic00 I am really sorry. Can you resolve the conflicts and I can do the review right now?

Comment thread src/libs/ReportActionsUtils.ts Resolved
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey @shubham1206agra Thanks for fast reply
Can you review now and run additional checks? I’ve commited directly from GitHub, and if additional changes needed, I’ll do them tonight if it’s not possible directly from Github

Comment thread src/libs/ReportUtils.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djordjemitrovic00 What case does this condition cover?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1206agra
I can confirm this later, but I’m fairly certain the issue occurs when we try to retrieve the name from the sidebar (which, as shown in the videos, is the message in the thread). If the message gets deleted in the meantime, the name shouldn't remain as the original text — it should display 'Deleted message' instead. So, we shouldn't rely on the attributes in this case.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are derived attributes, so they should be recalculated.

@djordjemitrovic00 djordjemitrovic00 Jun 11, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they are not recalculated until we send message I think (also I can confirm later this), but they are not recalculated automatically when we only receive message and not do any additional action(like clicking somewhere or sending message), is that something we should handle on our side? I can take a look after if needed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they are not recalculated until we send message I think

Not sure what you mean by this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we attempt to send a message in a thread, and the original message that started the thread is deleted in the meantime, the message shown in the sidebar still displays the original thread text instead of showing “Deleted message., and after we send the message, the thread in the sidebar updates to “Deleted message” if we're relying on derived attributes. However, if we’re not using derived attributes, the thread updates to “Deleted message” immediately upon deletion of the original message.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some bug in your PR if this is what is happening.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since on main, I can see the title changing immediately

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pulled and checked, seems like in meanwhile this was fixed. This wasn't happening before, so I'll delete this condition. Thanks for assistance! @shubham1206agra

@djordjemitrovic00
djordjemitrovic00 force-pushed the chat-thread-skeleton-new branch from 6dd9d52 to f1fc925 Compare June 11, 2025 21:41
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey @shubham1206agra can you check again, please?

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • xIf a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-06-16.at.9.44.32.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-06-16.at.9.31.43.PM.mov
iOS: HybridApp
Screen.Recording.2025-06-16.at.9.41.05.PM.mov
iOS: mWeb Safari
Screen.Recording.2025-06-16.at.9.29.01.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-16.at.9.17.29.PM.mov
MacOS: Desktop
Screen.Recording.2025-06-16.at.9.36.14.PM.mov

@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Thanks for putting reviewer checklist
I will fix reassure tests when I get home in around 1 hour, so if you are still there you can run again (since I can’t because this is my first PR)

@shubham1206agra

Copy link
Copy Markdown
Contributor

@djordjemitrovic00 Just merge main

djordjemitrovic00 and others added 5 commits June 16, 2025 19:33
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
@djordjemitrovic00
djordjemitrovic00 force-pushed the chat-thread-skeleton-new branch from f1fc925 to 5016af1 Compare June 16, 2025 17:34
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

I just did @shubham1206agra

@shubham1206agra shubham1206agra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on your first PR.

@melvin-bot
melvin-bot Bot requested a review from francoisl June 17, 2025 01:47
@djordjemitrovic00

Copy link
Copy Markdown
Contributor Author

Hey @francoisl can you take a look whenever you have time?

@francoisl
francoisl merged commit 6986581 into Expensify:main Jun 18, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot mentioned this pull request Jun 18, 2025
58 tasks done
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #62245.

Android 🤖 iOS 🍎
❌ FAILED ❌ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62245/index.html
The QR code can't be generated, because the Android build failed iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62245/NewExpensify.dmg https://62245.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/francoisl in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@lakchote

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify Expensify deleted a comment from github-actions Bot Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants