Repository navigation
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Failing test seems unrelated, I'll recheck it tomorrow. |
|
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
|
Videos look correct, though iOS native seems quite laggy? Maybe it will feel better on a real device. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-22.at.11.40.10.AM.movAndroid: mWeb ChromeScreen.Recording.2025-05-22.at.11.42.58.AM.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2025-05-22.at.11.45.01.AM.movMacOS: Chrome / SafariScreen.Recording.2025-05-22.at.11.22.27.AM.movScreen.Recording.2025-05-22.at.11.20.09.AM.movMacOS: DesktopScreen.Recording.2025-05-22.at.11.36.50.AM.mov |
|
Jest is failing @SzymczakJ |
Good catch, I think we should fix that! |
|
Today, I was busy with deploy blockers, I'll fix both thing tomorrow. |
|
so I guess wide screen padding should also be fixed, right @dubielzyk-expensify @shawnborton ? |
|
That's correct - we shouldn't have that extra padding at the top and bottom of the view - that seems like it was introduced recently. |
|
@shawnborton I fixed the spacings according to Figma, is that correct? Wide: |
|
Glad we caught the bug! |
|
Thanks for the PR, I will review it later today |
|
Asked if @DylanDylann could take over as Gandalf has other important tasks to handle |
|
@SzymczakJ conflicts |
allgandalf
left a comment
There was a problem hiding this comment.
nit picks, lets fix those while we resolve conflicts
| */ | ||
| scrollingVerticalBottomOffset.current = fullContentHeight - layoutMeasurement.height - contentOffset.y; | ||
|
|
||
| // we additionally track the top offset to be able to scroll to the new transaction when it's added |
There was a problem hiding this comment.
| // we additionally track the top offset to be able to scroll to the new transaction when it's added | |
| // We additionally track the top offset to be able to scroll to the new transaction when it's added |
| const scrollToNewTransaction = useCallback( | ||
| (pageY: number) => { | ||
| wrapperViewRef.current?.measureInWindow((x, y, w, height) => { | ||
| // if the new transaction is already visible, we don't need to scroll to it |
There was a problem hiding this comment.
| // if the new transaction is already visible, we don't need to scroll to it | |
| // If the new transaction is already visible, we don't need to scroll to it |
| if (pageY > 0 && pageY < height) { | ||
| return; | ||
| } |
| /** List of transactions belonging to one report */ | ||
| transactions: OnyxTypes.Transaction[]; | ||
|
|
||
| /** Report that these transactions belong to */ |
There was a problem hiding this comment.
| /** Report that these transactions belong to */ | |
| /** List of transactions that arrived when the report was open */ |
| it('should exclude hidden participants', () => { | ||
| const report: Report = { | ||
| ...createRandomReport(1), | ||
| ...createRandomReport(123), |
There was a problem hiding this comment.
is this change necessary ?
There was a problem hiding this comment.
I changed it in an attempt to fix a flaky test, I think that the test is already fixed so I will remove this change.
|
Comments fixed @allgandalf |
|
and they're back |
|
fixed @allgandalf |
|
@SzymczakJ we are having type failures |
allgandalf
left a comment
There was a problem hiding this comment.
lets fix test and we're good to go!
|
fixed typechecks, let's merge this! |
mountiny
left a comment
There was a problem hiding this comment.
Changes look good to me but they are quite extensive and might influence other parts of the codebase so please @allgandalf @SzymczakJ be on a look out for deploy blockers and remember that blockers are the most important task to work on if they come up
| const newTransactions = useMemo(() => { | ||
| if (!prevTransactions || !transactions || transactions.length <= prevTransactions.length) { | ||
| return CONST.EMPTY_ARRAY as unknown as OnyxTypes.Transaction[]; | ||
| } | ||
| return transactions.filter((transaction) => !prevTransactions?.some((prevTransaction) => prevTransaction.transactionID === transaction.transactionID)); | ||
| // Depending only on transactions is enough because prevTransactions is a helper object. | ||
| // eslint-disable-next-line react-compiler/react-compiler | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [transactions]); |
There was a problem hiding this comment.
Could we refactor this to avoid the eslint disable? there should be a way to do so
| const newTransactions = useMemo(() => { | ||
| if (!prevTransactions || reportTransactions.length <= prevTransactions.length) { | ||
| return CONST.EMPTY_ARRAY as unknown as OnyxTypes.Transaction[]; | ||
| } | ||
| return reportTransactions.filter((transaction) => !prevTransactions?.some((prevTransaction) => prevTransaction.transactionID === transaction.transactionID)); | ||
| // Depending only on transactions is enough because prevTransactions is a helper object. | ||
| // eslint-disable-next-line react-compiler/react-compiler | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [reportTransactions]); | ||
|
|
There was a problem hiding this comment.
Same here, we ideally do not want to add these exceptions
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀
|





Explanation of Change
This PR makes table report view auto-scroll to the expense if it's out of the scroll view.
Fixed Issues
$ #60418
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-13.at.17.25.17.mov
Android: mWeb Chrome
Screen.Recording.2025-05-13.at.18.09.38.mov
iOS: Native
Screen.Recording.2025-05-13.at.18.06.17.mov
iOS: mWeb Safari
Screen.Recording.2025-05-13.at.18.07.36.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-13.at.16.36.31.mov
MacOS: Desktop