Repository navigation
Fix formatting of tooltip in Spanish - #62892
Conversation
|
@shawnborton @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Good catch on that. |
|
iOS native has the same wrapping problem. I see there is an |
|
Text wrapping problem corrected by tweaking max-width; screenshots updated. |
|
@davidgelhar, could you also please change this PR title to something more descriptive? So it's clear what it fixes from the title itself. Thanks! |
|
Updated |
Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>
|
updated |
Yeah very good find, that looks off. |
|
@davidgelhar is this ready for a re-review? |
|
@eVoloshchak are you able to re-review this one today? We're on the cusp of releasing a bunch of new language translations for the F1, and we spotted this when checking some of the other languages we're adding. Thanks! |
Reviewer Checklist
Screenshots/Videos |
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀
|
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀
|
|
@davidgelhar This PR is failing because of issue #64597 bug.mp4 |
|
@davidgelhar can you please take a look? |
|
@MarioExpensify Looks like the calculation of where to center the tooltip is incorrect in the case where there are 4 buttons in the sidebar instead of 3. Looking for a fix... |
|
The logic for computing the horizontal shift of the tooltip was changed in this commit: |
|
@davidgelhar thank you for investigating the root cause, do you think you can come up with a fix? |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀
|
Yes I will work on a fix for this. |
|
@MarioExpensify upon further investigation it seems like we have conflicting design requirements, and 2 recent PRs have attempted to implement them both.
When there are only 3 buttons (with Scan in the middle) you could perhaps do both, but once the 4th (per diem) button is added, there is no way you can both center the tooltip in the sidebar and align it with the "Scan" button. Lining the tooltip up with the actual Scan button makes the most sense to me, so maybe we just change the test condition: Verify that the tooltip box Thoughts? |
|
Hmm, maybe we need to do something where:
Thought son something like that @Expensify/design ? |
|
@shawnborton @Expensify/design please let us know your thoughts so we can wrap this issue up. |
|
I think we should move forward with my suggestion above. |
|
I agree. |






















Explanation of Change
Fix 3 minor formatting issues with tooltip window when displaying a message in Spanish. (Problems occured with Spanish text because it is longer than the English text).
Fixed Issues
$ #60753
PROPOSAL: #60753 (comment)
Tests
Offline tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop