Skip to content

Fix formatting of tooltip in Spanish - #62892

Merged
MarioExpensify merged 19 commits into
Expensify:mainfrom
davidgelhar:fix/60753
Jun 17, 2025
Merged

MarioExpensify merged 19 commits into
Expensify:mainfrom
davidgelhar:fix/60753

Conversation

@davidgelhar

@davidgelhar davidgelhar commented May 27, 2025 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fix 3 minor formatting issues with tooltip window when displaying a message in Spanish. (Problems occured with Spanish text because it is longer than the English text).

  1. Get rid an unneeded flexWrap style that was causing the light bulb icon to display on a separate line from the text.
  2. Limit the width of the tooltip window so that it fits within the sidebar leaving some space on either side (aligned with green dashes)
  3. Add a missing space in the Spanish text

Fixed Issues

$ #60753
PROPOSAL: #60753 (comment)

Tests

  1. Log in to a new account (that has never used the "scan" feature
  2. In preferences, change language to Spanish
  3. Click the green "+" button, "Crear gasto", "Escanear"
  4. Verify that the tooltip box is centered in the sidebar, lines up with the green lines, and the text flows correctly.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native android native
Android: mWeb Chrome android mweb
iOS: Native ios native
iOS: mWeb Safari mweb safari
MacOS: Chrome / Safari mac-safari
MacOS: Desktop mac-desktop

@davidgelhar
davidgelhar marked this pull request as ready for review May 30, 2025 00:17
@davidgelhar
davidgelhar requested review from a team as code owners May 30, 2025 00:17
@melvin-bot
melvin-bot Bot requested review from eVoloshchak and shawnborton and removed request for a team May 30, 2025 00:17
@melvin-bot

melvin-bot Bot commented May 30, 2025

Copy link
Copy Markdown

@shawnborton @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Looks like the iOS Native version has a text wrapping bug:

CleanShot 2025-05-30 at 11 40 46@2x

@shawnborton

Copy link
Copy Markdown
Contributor

Good catch on that.

@davidgelhar

Copy link
Copy Markdown
Contributor Author

iOS native has the same wrapping problem. I see there is an index-native.txt in BaseGenericTooltip; looking to see if a change needs to be made there.

@davidgelhar

Copy link
Copy Markdown
Contributor Author

Text wrapping problem corrected by tweaking max-width; screenshots updated.
@shawnborton @eVoloshchak ready for review

Comment thread src/styles/variables.ts Resolved
Comment thread src/languages/es.ts Resolved
@eVoloshchak

Copy link
Copy Markdown
Contributor

@davidgelhar, could you also please change this PR title to something more descriptive? So it's clear what it fixes from the title itself. Thanks!

@davidgelhar davidgelhar changed the title Fix/60753 Fix formatting of tooltip in Spanish Jun 2, 2025
@davidgelhar

Copy link
Copy Markdown
Contributor Author

Updated

Comment thread src/styles/index.ts Resolved
davidgelhar and others added 3 commits June 2, 2025 15:30
@davidgelhar
davidgelhar requested a review from eVoloshchak June 3, 2025 09:21
@davidgelhar

Copy link
Copy Markdown
Contributor Author

updated

@eVoloshchak eVoloshchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right in the English locale

Screenshot 2025-06-08 at 16 20 15

It should either stay as before (one line)

Screenshot 2025-06-08 at 16 19 26

Or be split into two lines, so it's consistent with Spanish

Screenshot 2025-06-08 at 16 21 38

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

This doesn't look right in the English locale

Yeah very good find, that looks off.

@trjExpensify

Copy link
Copy Markdown
Contributor

@davidgelhar is this ready for a re-review?

@davidgelhar
davidgelhar requested a review from eVoloshchak June 17, 2025 10:53
@trjExpensify

Copy link
Copy Markdown
Contributor

@eVoloshchak are you able to re-review this one today? We're on the cusp of releasing a bunch of new language translations for the F1, and we spotted this when checking some of the other languages we're adding. Thanks!

@eVoloshchak

eVoloshchak commented Jun 17, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screenshot_1750180252
Screenshot_1750180232

Android: mWeb Chrome

Screenshot_1750180742
Screenshot_1750180726

iOS: HybridApp

Simulator Screenshot - iPhone 15 Pro - 2025-06-17 at 18 52 14
Simulator Screenshot - iPhone 15 Pro - 2025-06-17 at 18 51 28

iOS: mWeb Safari

Simulator Screenshot - iPhone 15 Pro - 2025-06-17 at 18 57 53
Simulator Screenshot - iPhone 15 Pro - 2025-06-17 at 18 57 39

MacOS: Chrome / Safari Screenshot 2025-06-17 at 19 16 08 Screenshot 2025-06-17 at 19 15 53 Screenshot 2025-06-17 at 19 13 42 Screenshot 2025-06-17 at 19 13 27
MacOS: Desktop Screenshot 2025-06-17 at 19 12 15 Screenshot 2025-06-17 at 19 12 01 Screenshot 2025-06-17 at 19 11 46 Screenshot 2025-06-17 at 19 11 35

@eVoloshchak eVoloshchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from MarioExpensify June 17, 2025 17:20

@MarioExpensify MarioExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MarioExpensify
MarioExpensify merged commit db5c8a8 into Expensify:main Jun 17, 2025
@github-actions github-actions Bot mentioned this pull request Jun 18, 2025
58 tasks done
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.69-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@vincdargento

Copy link
Copy Markdown

@davidgelhar This PR is failing because of issue #64597
The issue is reproducible in: Web, Desktop

bug.mp4

@MarioExpensify

Copy link
Copy Markdown
Contributor

@davidgelhar can you please take a look?

@davidgelhar

Copy link
Copy Markdown
Contributor Author

@MarioExpensify Looks like the calculation of where to center the tooltip is incorrect in the case where there are 4 buttons in the sidebar instead of 3. Looking for a fix...

@davidgelhar

Copy link
Copy Markdown
Contributor Author

The logic for computing the horizontal shift of the tooltip was changed in this commit:
96c1aa6#diff-5cf6cecf09ef8d27a21721096620c9582b94a5fc0c93f1f51089f4e0d951b96d
That may be why this worked ok in the PR branch but not once merged.

@MarioExpensify

Copy link
Copy Markdown
Contributor

@davidgelhar thank you for investigating the root cause, do you think you can come up with a fix?

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@davidgelhar

Copy link
Copy Markdown
Contributor Author

@davidgelhar thank you for investigating the root cause, do you think you can come up with a fix?

Yes I will work on a fix for this.

@davidgelhar

Copy link
Copy Markdown
Contributor Author

@MarioExpensify upon further investigation it seems like we have conflicting design requirements, and 2 recent PRs have attempted to implement them both.

  1. According to the discussion with @shawnborton in this PR, the tooltip should be centered in the sidebar, aligned with the green outline:
Image
  1. According to this recent fix [HOLD App#63642] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled #61084, the tooltip should be aligned with the "scan" button, not with the center of the sidebar, like this:

Image

When there are only 3 buttons (with Scan in the middle) you could perhaps do both, but once the 4th (per diem) button is added, there is no way you can both center the tooltip in the sidebar and align it with the "Scan" button.

Lining the tooltip up with the actual Scan button makes the most sense to me, so maybe we just change the test condition:

Verify that the tooltip box is centered in the sidebar, lines up with the green lines, is aligned with the Scan button and the text flows correctly.

Thoughts?

@shawnborton

Copy link
Copy Markdown
Contributor

Hmm, maybe we need to do something where:

  • on mobile, we always center the tooltip body to the viewport. Then we need to align the tooltip arrow to the correct tab/button above it (this changes depending on if there are 3 or 4)
  • on web/desktop, we just center the tooltip to the tab since we have more horizontal space to play with

Thought son something like that @Expensify/design ?

@MarioExpensify

Copy link
Copy Markdown
Contributor

@shawnborton @Expensify/design please let us know your thoughts so we can wrap this issue up.

@shawnborton

Copy link
Copy Markdown
Contributor

I think we should move forward with my suggestion above.

@dannymcclain

Copy link
Copy Markdown
Contributor

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants