Repository navigation
Deprecate DeleteMoneyRequestOnSearch - #74621
22 commits merged into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-11-18.at.15.52.07.movMacOS: Desktop |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Not relevant for product PR review. Unsubscribing.
|
Updated! |
|
Prettier check needs to be fixed |
|
Updated |
Pujan92
left a comment
There was a problem hiding this comment.
LGTM!
Screen.Recording.2025-11-18.at.15.52.07.mov
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
MarioExpensify
left a comment
There was a problem hiding this comment.
Changes looks good, just need to check the pipeline failures.
|
@luacmartins Conflicts |
|
@ looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Separate call to
DeleteMoneyRequestOnSearchinto multiple API calls for performance reasons. When we make a single API call with a big list of transactionIDs, that increases the chances of conflicts in the DB, which degrades performance. This PR splits the calls into N calls so that we handle each of the transactions being deleted separately.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/565758
Tests
Pre-condition:
Reports > ExpensesNetworktabX selecteddropdown, selectDeleteDeleteMoneyRequestOnSearchfor each transaction being deletedOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2025-11-11.at.1.51.47.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop