Repository navigation
Deprecate DeleteMoneyRequestOnSearch - #75972
Merged
MarioExpensify merged 24 commits intoNov 25, 2025
Merged
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
Bot
requested review from
JmillsExpensify and
Ollyws
and removed request for
a team and
JmillsExpensify
November 25, 2025 08:57
Contributor
Author
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-11-18.at.15.52.07.movMacOS: Desktop |
Pujan92
approved these changes
Nov 25, 2025
70 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.2.64-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
@luacmartins is OOO for a while and @flodnv asked if we could push the PR to the end. His PR is complete except for some workflow failures. I cannot push changes to that PR. So, I opened this PR and fixed the issues. I tested the changes on Chrome and they are working well.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/565758
PROPOSAL: NA
Tests
Pre-condition:
an account with multiple transactions that can be deleted
Steps:
Navigate to Reports > Expenses
Open the browser console and open the Network tab
Select several transactions
From the X selected dropdown, select Delete
Verify that there's one call to DeleteMoneyRequestOnSearch for each transaction being deleted
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
deleteMoneyRequest.mov
MacOS: Desktop