Repository navigation
feat: remove violation on transaction edit #75599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lakchote
merged 19 commits into
Expensify:main
from
mananjadhav:fix/mj-70484-remove-violation-on-edit
Nov 27, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f3dd273
feat: remove violation on transaction edit
mananjadhav be9d521
test: add test for violation removal
mananjadhav 90f8a19
style: lint fixes
mananjadhav c707a3c
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav a5e05ce
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav 3171768
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav cb551dc
refactor: move violation logic to utils
mananjadhav c2dbb99
docs: update comment
mananjadhav 3455e56
fix: lint error
mananjadhav d055d3b
refactor: lint fixes
mananjadhav fd8ee8c
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav a0ecd74
refactor: update auto reject expense logic to violtation utils
mananjadhav 0573518
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav 0cfff43
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav 111147a
refactor: rollback variable name
mananjadhav f228fe3
refactor: revert null check
mananjadhav 00859a8
refactor: remove ws space
mananjadhav bdd96cd
Merge branch 'main' of github.com:mananjadhav/App into fix/mj-70484-r…
mananjadhav ce8d9e2
fix: added hasMerchant field
mananjadhav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from issue #78578. We should remove the violation when the transaction is moved to a different report or when it is explicitly requested (e.g. from changeTransactionsReport).