Skip to content

Use the lowercase, unquoted term "uncategorized" for messages about expenses that were not categorized - #76199

Merged
NikkiWines merged 17 commits into
Expensify:mainfrom
c3024:Use-lowercase-wihtout-quotes-for-showing-that-an-expense-was-uncategorized-previously
Dec 3, 2025
Merged

NikkiWines merged 17 commits into
Expensify:mainfrom
c3024:Use-lowercase-wihtout-quotes-for-showing-that-an-expense-was-uncategorized-previously

Conversation

@c3024

@c3024 c3024 commented Nov 27, 2025 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When an expense category was uncategorized and later categorized, the change-category message displayed the previous category as “previously ‘Uncategorized’.” This PR updates it to “previously uncategorized” for clarity.

Fixed Issues

$ #75452
PROPOSAL: NA

Tests

Prerequisite:
Have a workspace with categories enabled.

Steps:
1. Create an expense in the workspace chat without selecting a category.
2. Wait for the Concierge message to appear in the chat.
3. If Concierge provides category choices, select one.
4. Verify that the Concierge message displays the word uncategorized in lowercase and without quotes.

  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2025-11-27 at 10 01 47 AM

@codecov

codecov Bot commented Nov 27, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ModifiedExpenseMessage.ts 53.42% <100.00%> (+0.81%) ⬆️
... and 110 files with indirect coverage changes

@c3024
c3024 requested a review from NikkiWines November 27, 2025 11:37

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small requests

Comment thread src/libs/ModifiedExpenseMessage.ts Outdated
removalFragments: string[],
changeFragments: string[],
shouldConvertToLowercase = true,
noQuotesForOldValue = false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to pass this as a param, I'd keep this as isUncategorized as that explains more clearly why we'd want this to be without quotes imo

Comment thread src/libs/ModifiedExpenseMessage.ts Outdated
Comment on lines +298 to +301
let oldCategory = reportActionOriginalMessage?.oldCategory ?? '';
const wasUncategorized = isCategoryMissing(oldCategory);

oldCategory = wasUncategorized ? oldCategory.toLowerCase() : getDecodedCategoryName(oldCategory);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let oldCategory = reportActionOriginalMessage?.oldCategory ?? '';
const wasUncategorized = isCategoryMissing(oldCategory);
oldCategory = wasUncategorized ? oldCategory.toLowerCase() : getDecodedCategoryName(oldCategory);
let oldCategory = reportActionOriginalMessage?.oldCategory ?? '';
const isUncategorized = isCategoryMissing(oldCategory);
oldCategory = isUncategorized ? oldCategory.toLowerCase() : getDecodedCategoryName(oldCategory);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this inside of buildMessageFragmentForValue? Instead of having the same logic twice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of keeping that function separate without mixing up the category concerns in it but it looks like it already handles merchant field logic so I added both the suggestions there.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this suggestion/change was appropriate. We would have avoided this if the logic wasn't placed in buildMessageFragmentForValue. Breaks one function/one purpose rule for buildMessageFragmentForValue. And getForReportActionTemp is a temporary function used for gradual migration so we are not going to have both getForReportAction and getForReportActionTemp for the future ( which means we won't have the logic twice)

@FitseTLT FitseTLT Dec 1, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @c3024 @NikkiWines on the ⬆️

@c3024 c3024 Dec 1, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, initially I felt the function buildMessageFragmentForValue should do its job without concerning itself with who calls it, and that approach looked more logical than even DRYing it. (I didn’t dig into the temp function temporariness.) Then, on Nikki’s review suggestion, I checked the function again, noticed the merchant logic already polluted included in it, and changed it for DRYing. Now, with the new bug, the old approach seems better to me as well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikkiWines 👀 before we make the change

@NikkiWines NikkiWines Dec 1, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I kind of disagree tbh, though I understand your reasoning. I do think this function is already sort of handling this sort of logic with the merchant changes @c3024 mentioned, but I agree it's mixing responsibilities a bit.

However, I still don't like the duplicated code and the fact that any future code would have to know to potentially perform this same "update category" logic / know to reference the existing code, so that we don't unintentionally surface this in the future. We also don't know if (or when 😅) getForReportActionTemp will be cleaned up... "todos" are known to linger.

We could alternatively do something similar to getCleanedTagName and have a separate function that we call for oldCategory that handles the naming changes - that reduces the code duplication and keeps the logic outside of buildMessageFragmentForValue, though it still leaves the potential pitfal I mentioned above... but it's maybe a happy medium.

Thoughts?

@c3024 c3024 Dec 2, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s leave it as it is now, as the other choices don’t seem significantly better.

cc: @FitseTLT

@c3024
c3024 marked this pull request as ready for review November 28, 2025 07:06
@c3024
c3024 requested review from a team as code owners November 28, 2025 07:06
@melvin-bot
melvin-bot Bot requested review from FitseTLT and removed request for a team November 28, 2025 07:06
@melvin-bot

melvin-bot Bot commented Nov 28, 2025

Copy link
Copy Markdown

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 28, 2025 07:06
@c3024
c3024 requested a review from dannymcclain November 28, 2025 07:07
NikkiWines
NikkiWines previously approved these changes Nov 28, 2025

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@c3024
c3024 requested a review from a team December 1, 2025 07:03
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

LGTM 👍

@dannymcclain

Copy link
Copy Markdown
Contributor

Same 👍

@FitseTLT

FitseTLT commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

@c3024 this has stopped working due to the change here

let categoryLabel = translateLocal('common.category').toLowerCase();

@c3024

c3024 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@FitseTLT

What has stopped working?

@FitseTLT

FitseTLT commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

The very thing you are trying to achieve on the pr

@c3024

c3024 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

Oh, understood. Pushing a fix.

@c3024

c3024 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

Fixed.

Screenshot 2025-12-01 at 9 59 59 PM

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@c3024

c3024 commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

@FitseTLT

Could you please continue reviewing the PR?

// If the valueName is category and the old value was Uncategorized, show it in lowercase without quotes
let oldValueToDisplay;
// eslint-disable-next-line @typescript-eslint/no-deprecated
if (valueName.includes(translateLocal('common.category').toLowerCase()) && isCategoryMissing(oldValue)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason to use includes here instead of direct equality check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The categoryLabel can be appended with other text if it is derived based on AI etc.

let categoryLabel = translateLocal('common.category').toLowerCase();
// Add attribution suffix based on source
if (reportActionOriginalMessage?.source === CONST.CATEGORY_SOURCE.AI) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
categoryLabel += ` ${translateLocal('iou.basedOnAI')}`;
} else if (reportActionOriginalMessage?.source === CONST.CATEGORY_SOURCE.MCC) {
// eslint-disable-next-line @typescript-eslint/no-deprecated
const policy = getPolicy(policyID);
const isAdmin = isPolicyAdmin(policy, currentUserLogin);
// For admins, create a hyperlink to the workspace rules page
if (isAdmin && policy?.id) {
const rulesLink = `${environmentURL}/${ROUTES.WORKSPACE_RULES.getRoute(policy.id)}`;
// eslint-disable-next-line @typescript-eslint/no-deprecated
categoryLabel += ` ${translateLocal('iou.basedOnMCC', {rulesLink})}`;
} else {
// eslint-disable-next-line @typescript-eslint/no-deprecated
categoryLabel += ` ${translateLocal('iou.basedOnMCC', {rulesLink: ''})}`;
}
}

@FitseTLT FitseTLT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome image
iOS: HybridApp image
iOS: mWeb Safari image
MacOS: Chrome / Safari image

@melvin-bot

melvin-bot Bot commented Dec 3, 2025

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #75452 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from neil-marcellini December 3, 2025 18:57
@NikkiWines

Copy link
Copy Markdown
Contributor

😤 i am an internal engineer!

@FitseTLT

FitseTLT commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@NikkiWines all yours

@NikkiWines
NikkiWines removed the request for review from neil-marcellini December 3, 2025 18:59
@NikkiWines
NikkiWines merged commit 697acbb into Expensify:main Dec 3, 2025
3 of 5 checks passed
@OSBotify

OSBotify commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 4, 2025
60 tasks done
@OSBotify

OSBotify commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.72-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants