Repository navigation
Use the lowercase, unquoted term "uncategorized" for messages about expenses that were not categorized #76199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NikkiWines
merged 17 commits into
Expensify:main
from
c3024:Use-lowercase-wihtout-quotes-for-showing-that-an-expense-was-uncategorized-previously
Dec 3, 2025
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
af34658
use lowercase without quotes for uncategorized
c3024 b8e143e
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 492666d
refactor the old category code
c3024 596936f
prettier
c3024 ed58257
lint
c3024 723dc59
omit quotes only for uncategorized
c3024 c9dda07
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 9ea9053
DRY
c3024 60d2107
cleanup
c3024 4d3c3f8
remove unnecessary default parameter
c3024 39a86a9
remove nested ternary as lint complains
c3024 d3b2dbb
move lint override to correct place
c3024 3107770
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 ca3f573
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 5fa2791
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 640565a
Merge branch 'main' into Use-lowercase-wihtout-quotes-for-showing-tha…
c3024 1133f0c
include the lower case in check
c3024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the reason to use
includeshere instead of direct equality check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The categoryLabel can be appended with other text if it is derived based on AI etc.
App/src/libs/ModifiedExpenseMessage.ts
Lines 303 to 323 in 45f1f97