Repository navigation
[No QA] Change place where we are tracking metric for transition from OD to ND - #81670
Conversation
… add it in onSplashHide of Expensify for improved telemetry tracking.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Let me know when its ready for review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd9d61d8f6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const onSplashHide = useCallback(() => { | ||
| setSplashScreenState(CONST.BOOT_SPLASH_STATE.HIDDEN); | ||
| endSpan(CONST.TELEMETRY.SPAN_OD_ND_TRANSITION); |
There was a problem hiding this comment.
End OD→ND span even when splash skips hide callback
When the hybrid app transition comes from a logged-out OldDot state, HybridAppHandler sets splashScreenState directly to HIDDEN (loggedOutFromOldDot ? HIDDEN : READY_TO_BE_HIDDEN), which means shouldHideSplash never renders SplashScreenHider, so onSplashHide doesn’t fire. With this change, endSpan(SPAN_OD_ND_TRANSITION) only runs inside onSplashHide, so the OD→ND span can remain open indefinitely for that flow, skewing telemetry. Consider ending the span at the transition completion regardless of whether the splash hide callback runs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Okay so this would be: User in Expensify Classic signs out, we switch to NewDot because we always use NewDot as the authentication page starting point.
Makes sense I think to resolve this, though it is an uncommon flow. @kubabutkiewicz would the simplest solution would be to have an additional endSpan in HybridAppHandler?
There was a problem hiding this comment.
Yeah I was also thinking about that to add the additional span here, will do that
Hi, @abzokhattab I'm removing the C+ review here, will handle myself. Thank you |
|
No product review required |
3e7e7c1
|
Hey I pushed one more change to add additional span #81670 (comment) |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Great, thank you. Lets merge |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.18-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀
|
Explanation of Change
Fixed Issues
$#77172
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari