Repository navigation
[No QA] Change place where we are tracking metric for transition from OD to ND #81670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Julesssss
merged 2 commits into
Expensify:main
from
callstack-internal:perf-change-place-where-we-end-span-for-transition-from-od-to-nd
Feb 11, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the hybrid app transition comes from a logged-out OldDot state,
HybridAppHandlersetssplashScreenStatedirectly toHIDDEN(loggedOutFromOldDot ? HIDDEN : READY_TO_BE_HIDDEN), which meansshouldHideSplashnever rendersSplashScreenHider, soonSplashHidedoesn’t fire. With this change,endSpan(SPAN_OD_ND_TRANSITION)only runs insideonSplashHide, so the OD→ND span can remain open indefinitely for that flow, skewing telemetry. Consider ending the span at the transition completion regardless of whether the splash hide callback runs.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so this would be: User in Expensify Classic signs out, we switch to NewDot because we always use NewDot as the authentication page starting point.
Makes sense I think to resolve this, though it is an uncommon flow. @kubabutkiewicz would the simplest solution would be to have an additional endSpan in
HybridAppHandler?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was also thinking about that to add the additional span here, will do that