Skip to content

Change 'comment' to 'description' in report modified action - #82429

Closed
JS00001 wants to merge 4 commits into
mainfrom
jsenyitko-fix-action-message
Closed

JS00001 wants to merge 4 commits into
mainfrom
jsenyitko-fix-action-message

Conversation

@JS00001

@JS00001 JS00001 commented Feb 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

We dont want to render 'comment', but instead, 'description'

Fixed Issues

$ #82241

Tests

Create a new merchant rule that matches "Merchant" and updates description to "Hello"
Create a new expense
Ensure the system messages says "set the description", rather than "set the comment"

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

image

@JS00001 JS00001 self-assigned this Feb 13, 2026
@JS00001
JS00001 requested review from a team as code owners February 13, 2026 15:16
@melvin-bot
melvin-bot Bot requested review from eVoloshchak and heyjennahay and removed request for a team February 13, 2026 15:16
@melvin-bot

melvin-bot Bot commented Feb 13, 2026

Copy link
Copy Markdown

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team February 13, 2026 15:16
@JS00001
JS00001 removed the request for review from eVoloshchak February 13, 2026 15:17
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index c80404a5..adc364a5 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1527,6 +1527,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `setze ${field} auf „${value}“` : `${field} zu „${value}“`;
             },
             format: (fragments: string, route: string) => `${fragments} über <a href="${route}">Workspace-Regeln</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `Beschreibung auf „${value}“ festlegen` : `Beschreibung zu „${value}“`),
         },
         duplicateNonDefaultWorkspacePerDiemError:
             'Sie können Per-Diem-Ausgaben nicht über mehrere Workspaces hinweg duplizieren, da sich die Sätze zwischen den Workspaces unterscheiden können.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 61d69123..469a80b1 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1533,6 +1533,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `définir ${field} sur « ${value} »` : `${field} à « ${value} »`;
             },
             format: (fragments: string, route: string) => `${fragments} via les <a href="${route}">règles de l’espace de travail</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `définir la description sur « ${value} »` : `description à « ${value} »`),
         },
         duplicateNonDefaultWorkspacePerDiemError:
             'Vous ne pouvez pas dupliquer les indemnités journalières entre plusieurs espaces de travail, car les taux peuvent différer d’un espace de travail à l’autre.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 8058d5b9..adb65350 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1524,6 +1524,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `imposta ${field} su "${value}"` : `${field} a "${value}"`;
             },
             format: (fragments: string, route: string) => `${fragments} tramite le <a href="${route}">regole dello spazio di lavoro</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `imposta la descrizione su "${value}"` : `descrizione in “${value}”`),
         },
         duplicateNonDefaultWorkspacePerDiemError: 'Non puoi duplicare le spese di diaria tra diversi spazi di lavoro perché le tariffe potrebbero essere diverse tra gli spazi di lavoro.',
     },
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d4af68a8..2dcb668d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1518,6 +1518,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `${field} を「${value}」に設定する` : `${field} から「${value}」へ`;
             },
             format: (fragments: string, route: string) => `${fragments}(<a href="${route}">ワークスペースルール</a>経由)`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `説明を「${value}」に設定` : `説明を「${value}」に設定`),
         },
         duplicateNonDefaultWorkspacePerDiemError: 'ワークスペースごとに日当レートが異なる場合があるため、日当経費をワークスペース間で複製することはできません。',
     },
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 7993ff37..0a603e75 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1523,6 +1523,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `stel de ${field} in op "${value}"` : `${field} naar "${value}"`;
             },
             format: (fragments: string, route: string) => `${fragments} via <a href="${route}">werkruimte­regels</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `stel de beschrijving in op ‘${value}’` : `beschrijving naar "${value}"`),
         },
         duplicateNonDefaultWorkspacePerDiemError: 'Je kunt dagvergoedingen niet dupliceren tussen werkruimtes, omdat de tarieven per werkruimte kunnen verschillen.',
     },
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 94515332..2028b2e3 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1522,6 +1522,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `ustaw ${field} na „${value}”` : `${field} na „${value}”`;
             },
             format: (fragments: string, route: string) => `${fragments} przez <a href="${route}">zasady przestrzeni roboczej</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `ustaw opis na „${value}”` : `opis na „${value}”`),
         },
         duplicateNonDefaultWorkspacePerDiemError:
             'Nie możesz duplikować wydatków z tytułu diet między przestrzeniami roboczymi, ponieważ stawki mogą się różnić między poszczególnymi przestrzeniami.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 8f2b6410..447c92c5 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1520,6 +1520,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `defina ${field} como "${value}"` : `${field} para "${value}"`;
             },
             format: (fragments: string, route: string) => `${fragments} via <a href="${route}">regras do espaço de trabalho</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `definir a descrição como "${value}"` : `descrição para "${value}"`),
         },
         duplicateNonDefaultWorkspacePerDiemError: 'Você não pode duplicar despesas de diárias entre espaços de trabalho porque as tarifas podem variar entre eles.',
     },
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index f3a6ef79..21f87ad1 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1498,6 +1498,7 @@ const translations: TranslationDeepObject<typeof en> = {
                 return isFirst ? `将 ${field} 设置为“${value}”` : `${field} 至 “${value}”`;
             },
             format: (fragments: string, route: string) => `${fragments} 通过 <a href="${route}">工作区规则</a>`,
+            description: (value: string, isFirst: boolean) => (isFirst ? `将描述设置为“${value}”` : `描述为“${value}”`),
         },
         duplicateNonDefaultWorkspacePerDiemError: '您无法在不同工作区之间复制每日津贴报销,因为各工作区的补贴标准可能不同。',
     },

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Code Review - Inline Feedback

src/types/onyx/OriginalMessage.ts

Issue: Type Redundancy

The PolicyRulesModifiedFields type now contains both comment and description fields:

/** The value that the comment was changed to */
comment?: string;

/** The value that the description was changed to */
description?: string;

Problem: This creates confusion about which field should be used. Based on the implementation in ModifiedExpenseMessage.ts, the backend sends comment which is then displayed as "description" to users. Having both fields in the type suggests they serve different purposes, when in reality they represent the same data.

Recommendation: Remove the description field since it's unused, or clarify in comments why both fields exist if they serve different purposes from the backend.

@situchan

Copy link
Copy Markdown
Contributor

This is already handled in #82325

@situchan situchan mentioned this pull request Feb 13, 2026
52 of 53 tasks

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8472ba69f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}

if (key === 'comment') {
return translate('iou.policyRulesModifiedFields.description', updatedValue, isFirst);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add missing locale entries for policyRulesModifiedFields.description

This branch now calls translate('iou.policyRulesModifiedFields.description', ...), but the commit only adds that key in src/languages/en.ts; the other locale files under src/languages still define policyRulesModifiedFields without description. For users on non-English locales, a policy-rule update that comes through the comment field will hit a missing translation path, which translate() treats as an error (throwing in dev and falling back to raw key text in production), so the modified-expense system message is broken in those locales.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Feb 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ModifiedExpenseMessage.ts 79.26% <50.00%> (-0.18%) ⬇️
... and 124 files with indirect coverage changes

@JS00001 JS00001 closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants