Repository navigation
Handle mentions in the description - #82325
Conversation
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-02-13.at.3.47.33.AM.mov |
Code Review SummaryI've completed a review of this PR. The implementation is mostly solid with one documentation issue to address: Issue FoundDocumentation Clarity (CONSISTENCY-2) - The JSDoc for the new /** The value that the description was changed to */
comment?: string;
/** The value that the description was changed to */
description?: string;This creates confusion about the purpose of each field. The documentation should clarify their relationship. Consider: /** The description value as stored by the backend (displayed as 'description' in UI) */
comment?: string;
/** The value that the description was changed to */
description?: string;What's Working Well✅ The markdown conversion logic correctly handles mentions using The implementation effectively addresses the requirement to display mentions in the description field. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
Looks good
- Please address #82325 (comment)
Verify that ...is missing in Tests step- Be good to add unit tests for
getPolicyRulesModifiedMessagefunction
trjExpensify
left a comment
There was a problem hiding this comment.
No, no. I think you should update the description to:
(∩ ͡° ͜ʖ ͡°)⊃━☆゚. *
| /** The value that the description was changed to (backend uses "comment" key) */ | ||
| comment?: string; | ||
|
|
||
| /** The value that the description was changed to (display key, mapped from "comment") */ |
There was a problem hiding this comment.
@luacmartins bit confused, what is stored in description vs comment?
There was a problem hiding this comment.
Agreed, why do we have this?
There was a problem hiding this comment.
Now you understand why this is needed while working on #82429?
| /** The value that the description was changed to (backend uses "comment" key) */ | ||
| comment?: string; | ||
|
|
||
| /** The value that the description was changed to (display key, mapped from "comment") */ |
There was a problem hiding this comment.
Agreed, why do we have this?
| comment?: string; | ||
|
|
||
| /** The value that the description was changed to (display key, mapped from "comment") */ | ||
| description?: string; |
There was a problem hiding this comment.
If description doesn't exist in Onyx data, maybe remove it?
There was a problem hiding this comment.
It's a type thing. We can remove it, but we'll have to update the translation types.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.19-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀
|
Explanation of Change
Converts the
MODIFIEDEXPENSEdescription field to markdown so that we can properly display the field when it includes mentions.Fixed Issues
$ #82245
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari