Repository navigation
Revert "Create per-diem in selfDM if auto reporting is disabled" - #84172
Conversation
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e51080822
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| setMoneyRequestParticipantsFromReport(transactionID, targetReport, accountID, false); | ||
| setTransactionReport(transactionID, {reportID: policyExpenseReportID}, true); | ||
| if (iouType === CONST.IOU.TYPE.TRACK) { | ||
| setMoneyRequestParticipantsFromReport(transactionID, selfDMReport, accountID, false); |
There was a problem hiding this comment.
Guard track flow when self-DM report is unavailable
In the track branch, setMoneyRequestParticipantsFromReport is now called with selfDMReport without verifying that the self-DM report has loaded. When findSelfDMReportID() has not resolved yet, this passes undefined, which produces an empty participant list; the confirmation step then bails out in submitPerDiemExpense because there is no first participant, so submit becomes a no-op. The previous code path avoided this by returning early when the derived target report was missing.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…per-diem (cherry picked from commit 7a49eaf) (cherry-picked to staging by blimpich)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-1 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.32-0 🚀
|
|
Deploy Blocker #84358 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀
|
Straight revert of #82230
$ #84167
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari