Skip to content

Revert "Fix not here page after moving IOU report to workspace" (#87167) — fixes #88434 - #88486

Closed
neil-marcellini wants to merge 1 commit into
mainfrom
neil/revert-87167-fix-88434
Closed

neil-marcellini wants to merge 1 commit into
mainfrom
neil/revert-87167-fix-88434

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Apr 21, 2026 •

Copy link
Copy Markdown
Contributor

(Neil's AI agent)

Explanation of Change

Reverts #87167 ("Fix not here page after moving IOU report to workspace"), which was identified via git bisect --first-parent as the first-bad commit that causes #88434 on staging.

Bisect result

Why this is likely the regression

#87167 introduced LinkedActionNotFoundGuard cleanup that, when linkedAction becomes null (removed from Onyx), clears the stale route param to avoid a "Not here" page on the linked-action flow. That cleanup appears to be firing on other RHP screens (including SplitExpensePage) where the screen legitimately has no reportActionIDFromRoute present, clearing params and in turn making SplitExpensePage render its own FullPageNotFoundView via !reportID || isEmptyObject(draftTransaction) || !isSplitAvailable.

Revert is the least-risky path to unblock the deploy; a surgical fix that narrows the cleanup's trigger (e.g., gating on the RHP screen name or requiring reportActionIDFromRoute to have been present in the URL) can land in a follow-up PR authored by the original author.

Fixed Issues

$ #88434

Tests

Same repro steps as the original issue:

  1. Create a new expense in a workspace chat (FAB → Create expense → enter amount → Next → submitter).
  2. Open the expense → Details → Split.
  3. On SplitExpensePage, tap the Date tab, then tap the Date cell on a split row.
  4. Pick two dates and click Save.
  5. Verify you land back on the Split view (Date tab) with all split rows intact — not on a "Not here" (FullPageNotFoundView) page.
  • Verify that no errors appear in the JS console

Also re-verify the original flow fixed by #87167 still needs a permanent fix (tracked by issue #85753):

  1. Open a 1:1 DM where an IOU expense was received.
  2. Copy the IOU preview link and paste it into your self-DM.
  3. Click the link → open the expense → More → Change workspace → select a workspace.
  4. Close the RHP.
  5. Expected after this revert: the "Not here" page for the original [$250] [Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace #85753 flow returns (regression vs. Fix not here page after moving IOU report to workspace #87167). A follow-up is needed to $ [$250] [Due for payment 2026-04-30] Expense - Not here page opens after moving IOU report to workspace #85753 without the over-broad cleanup.

Offline tests

N/A — pure revert of client-side navigation cleanup code.

QA Steps

Same as the Tests section above — the first flow (split dates) is the primary regression being unblocked.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
  • Platform matrix (this is a revert of a previously-merged fix; testing limited to the affected flow)

Screenshots/Videos

Bisect log
git bisect start '--first-parent'
git bisect bad e67e5eb57aecd5e66c5ed89a186ecb56f037ee6c    # Merge PR #87167 (FIRST BAD)
git bisect good f951e1c831230872637d6f5aee64a7acbbee8a82   # 9.3.60-0 merge base (assumed good — prod clean)
git bisect good b538fb3899bee64b14789e340152b1e8aebec0d8   # Merge PR #87870
git bisect good 5368fb1e8ffd85b7230ce78f2017ee378fa55fd1   # Merge PR #88211
git bisect good 992fb32b3f9149b77e217c3ac85b53810caa3fd1   # Merge PR #87689
git bisect good d3831cc9db5f10355273d297908928998ccd2bff   # Merge PR #87834
git bisect good bebf1bb60fd3d0433909b2462ccd0bed6df3353f   # Merge PR #88242
git bisect good 03023c12266021fea8aedc64fae4107037cfe564   # Merge PR #82042 (LAST GOOD — parent of #87167)
# first bad commit: e67e5eb57aecd5e66c5ed89a186ecb56f037ee6c Merge PR #87167

…eAfterMovingIOUToWorkspace"

This reverts commit e67e5eb, reversing
changes made to 03023c1.
@neil-marcellini

Copy link
Copy Markdown
Contributor Author

Hmm, I think there was some mistake with my git bisect process because this does not fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant