Repository navigation
Revert "Fix not here page after moving IOU report to workspace" (#87167) — fixes #88434 - #88486
Closed
neil-marcellini wants to merge 1 commit into
Closed
neil-marcellini wants to merge 1 commit into
neil-marcellini wants to merge 1 commit into
Conversation
Contributor
Author
|
Hmm, I think there was some mistake with my git bisect process because this does not fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Neil's AI agent)
Explanation of Change
Reverts #87167 ("Fix not here page after moving IOU report to workspace"), which was identified via
git bisect --first-parentas the first-bad commit that causes #88434 on staging.Bisect result
e67e5eb57ae— Merge PR Fix not here page after moving IOU report to workspace #8716703023c12266— parent of Fix not here page after moving IOU report to workspace #87167 (Merge PR Fix: Web-Scan-Scan expense from Reports, the existing report disappears in filter for a while #82042)f951e1c8312(9.3.60-0, merge base of prod/staging) →origin/stagingWhy this is likely the regression
#87167 introduced
LinkedActionNotFoundGuardcleanup that, whenlinkedActionbecomesnull(removed from Onyx), clears the stale route param to avoid a "Not here" page on the linked-action flow. That cleanup appears to be firing on other RHP screens (includingSplitExpensePage) where the screen legitimately has noreportActionIDFromRoutepresent, clearing params and in turn makingSplitExpensePagerender its ownFullPageNotFoundViewvia!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable.Revert is the least-risky path to unblock the deploy; a surgical fix that narrows the cleanup's trigger (e.g., gating on the RHP screen name or requiring
reportActionIDFromRouteto have been present in the URL) can land in a follow-up PR authored by the original author.Fixed Issues
$ #88434
Tests
Same repro steps as the original issue:
SplitExpensePage, tap the Date tab, then tap the Date cell on a split row.FullPageNotFoundView) page.Also re-verify the original flow fixed by #87167 still needs a permanent fix (tracked by issue #85753):
Offline tests
N/A — pure revert of client-side navigation cleanup code.
QA Steps
Same as the Tests section above — the first flow (split dates) is the primary regression being unblocked.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
Bisect log