Repository navigation
[No QA] Add Travel Invoicing CR to QBO advanced page - #91220
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
flaky tests |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
I didn't see any failed checks |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review complete — docs update required. This PR adds a new user-facing Sync travel invoicing settlements toggle and Reconciliation account picker to the QuickBooks Online Advanced settings page (via the shared Draft docs PR: #92799 What the docs change coversNew article:
All UI labels (Sync travel invoicing settlements, Reconciliation account, Advanced, Auto-sync) were verified against the exact strings in @allgandalf, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Imports the shared
TravelInvoicingContinuousReconciliationSectioncomponent (shipped in #91027) into the QBO advanced accounting page so admins can toggle Travel Invoicing continuous reconciliation and pick the reconciliation bank account on QuickBooks Online workspaces. The component handles the toggle, navigation to the bank account picker, and offline pending action display, withconnectionName={CONST.POLICY.CONNECTIONS.NAME.QBO}passed through. Backend changes are in https://github.com/Expensify/Integration-Server/pull/8973.Fixed Issues
$ #90987
PROPOSAL:
Tests
./script/clitools.sh expensifytravel:setupInvoicing --enable) and provision Expensify Cards (./script/clitools.sh expensifycard:policy)Offline tests
Turn off network, toggle the TI CR row. Verify the change displays with pending action styling, then settles once the network is back. Same for selecting a reconciliation bank account.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari