Repository navigation
Conversation
Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
|
The failing Root cause: The The step does not run Why it's not this PR: This PR only adds a single docs markdown file — the failure is in the workflow's apt setup, not in any docs content. The identical step succeeded on Recommended fix (separate infra PR — out of scope for this docs PR):
I did not push to this branch because the failure is unrelated to the docs change, and the fix belongs in the workflow file — which affects all docs PRs and deploys, so it should land via its own infra PR rather than being bolted onto this documentation change. |
Explanation of Change
Documents the new Sync travel invoicing settlements toggle and Reconciliation account picker added to the QuickBooks Online Advanced settings page in Expensify/App#91220.
That PR wired the shared
TravelInvoicingContinuousReconciliationSectioncomponent into the QBO advanced accounting page, letting Workspace Admins toggle continuous reconciliation of travel invoicing settlements and pick the bank account those settlements are reconciled against. This was not covered anywhere underdocs/articles, so this PR adds a new help article:docs/articles/new-expensify/connections/quickbooks-online/Sync-Travel-Invoicing-Settlements-With-QuickBooks-Online.mdThe article follows
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md. All UI labels (Sync travel invoicing settlements, Reconciliation account, Advanced, Auto-sync) match the exact strings fromsrc/languages/en.ts.Fixed Issues
$ #90987
Docs follow-up to #91220
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
This is a documentation-only change. Review the rendered article for accuracy against the live QuickBooks Online Advanced settings page.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
@allgandalf, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.