Skip to content

Docs updates for E/A#91220 document Sync travel invoicing settlements for QuickBooks Online - #92799

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-qbo-travel-invoicing-cr
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docs-qbo-travel-invoicing-cr

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Documents the new Sync travel invoicing settlements toggle and Reconciliation account picker added to the QuickBooks Online Advanced settings page in Expensify/App#91220.

That PR wired the shared TravelInvoicingContinuousReconciliationSection component into the QBO advanced accounting page, letting Workspace Admins toggle continuous reconciliation of travel invoicing settlements and pick the bank account those settlements are reconciled against. This was not covered anywhere under docs/articles, so this PR adds a new help article:

  • docs/articles/new-expensify/connections/quickbooks-online/Sync-Travel-Invoicing-Settlements-With-QuickBooks-Online.md

The article follows docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. All UI labels (Sync travel invoicing settlements, Reconciliation account, Advanced, Auto-sync) match the exact strings from src/languages/en.ts.

Fixed Issues

$ #90987

Docs follow-up to #91220

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

This is a documentation-only change. Review the rendered article for accuracy against the live QuickBooks Online Advanced settings page.

  • Verify that no errors appear in the JS console

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

@allgandalf, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team June 5, 2026 18:20
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing Deploy ExpensifyHelp / build check is an unrelated CI infrastructure failure, not a problem with this PR. I have not pushed any change.

Root cause: The build job fails at the Install pcregrep step (.github/workflows/deployExpensifyHelp.yml:40-41), which runs sudo apt-get install -y pcregrep on the blacksmith-2vcpu-ubuntu-2404 runner and errors with:

E: Unable to locate package pcregrep

The step does not run apt-get update first, so it depends entirely on the runner image's prebaked apt index.

Why it's not this PR: This PR only adds a single docs markdown file — the failure is in the workflow's apt setup, not in any docs content. The identical step succeeded on main ~3 hours earlier (run 27022788332, 15:05Z) on the same runner label, then failed across 5 docs PRs in the 18:19–18:21Z batch. That points to a runner-image / apt-index change, not to anything in the code.

Recommended fix (separate infra PR — out of scope for this docs PR):

  • Add sudo apt-get update before the install, or
  • Switch to pcre2grep (package pcre2-utils, the Ubuntu 24.04 replacement for the removed pcre3/pcregrep) and update the two call sites in .github/scripts/enforceVideoFormats.sh.
  • Re-running the failed job may also clear it if the apt index was only transiently stale.

I did not push to this branch because the failure is unrelated to the docs change, and the fix belongs in the workflow file — which affects all docs PRs and deploys, so it should land via its own infra PR rather than being bolted onto this documentation change.

@allgandalf allgandalf closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants