Repository navigation
Conversation
6c094b7 to
0c50a26
Compare
…port-transaction-thread
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
Code ReviewThe overall approach — extracting duplicated transaction thread logic into a shared React context — is clean and the perf win is solid. All CI checks pass and the deduplication is well-scoped. However, I agree with The issueBefore this PR, const [reportActionsForParent] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${...}`);
const requestParentReportAction = reportActionsForParent?.[transactionThreadReport.parentReportActionID];After this PR, it comes from the context, which finds it via const isDeletedMoneyRequest = isDeletedParentAction(action) && isMoneyRequestAction(action);
return !isDeletedMoneyRequest && ...;If the parent IOU action is soft-deleted (or outside the current pagination window), the filtered list won't contain it → SuggestionEither:
Option 2 seems cleaner since the parent action lookup semantically shouldn't be subject to view-level filtering. Everything else in the PR looks good — the context shape is well-typed, the provider is placed at the right level in |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Use direct REPORT_ACTIONS key lookup for requestParentReportAction so Hold/Unhold keep working when the parent IOU is filtered or unpaginated. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@MelvinBot does last commit resolve your concern? |
|
Yes, the last commit resolves the concern. The parent action lookup now uses the raw Onyx |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.90-0 🚀
Bundle Size Analysis (Sentry): |
Help site review — no changes requiredI reviewed the changes in this PR against the help site files under Conclusion: No help site documentation changes are required. Why: This is a pure internal performance refactor. It extracts the money-report transaction-thread logic into a new React context (
Because nothing a Help article would describe has changed, there is no documentation to add or update, and no draft docs PR is needed. @TMisiukiewicz — if you believe a specific behavior visible to users did change here, let me know which one and I'll re-evaluate and create a docs PR if warranted. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀
|
Explanation of Change
The same heavy logic is called across multiple components and hooks related to money request header when opening the report. This PR introduces context that holds the value in a single place, sharing it across those components and hooks.
Perf gain on iOS:
ManualOpenReport2.1s -> 1.9s (13% improvement)Fixed Issues
$ #91947
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari