Repository navigation
perf: extract money report transaction thread into context #91946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 4 commits into
Expensify:main
from
callstack-internal:perf/extract-money-report-transaction-thread
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0c50a26
extract money report transaction thread into context
TMisiukiewicz 56bf977
Merge remote-tracking branch 'origin/main' into perf/extract-money-re…
TMisiukiewicz 6b5fb76
fix: resolve parent report action from raw Onyx collection
TMisiukiewicz 3ee125b
add tests & docs
TMisiukiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import React, {createContext, useContext} from 'react'; | ||
| import type {ReactNode} from 'react'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import useTransactionThreadReport from '@hooks/useTransactionThreadReport'; | ||
| import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID'; | ||
| import {getOriginalMessage, isMoneyRequestAction} from '@libs/ReportActionsUtils'; | ||
| import type CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type * as OnyxTypes from '@src/types/onyx'; | ||
|
|
||
| type MoneyReportTransactionThreadContextValue = { | ||
| /** The transaction ID from the parent IOU report action */ | ||
| iouTransactionID: string | undefined; | ||
| /** The parent IOU report action for the transaction thread */ | ||
| requestParentReportAction: OnyxTypes.ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> | null; | ||
| /** The transaction thread report ID */ | ||
| transactionThreadReportID: string | undefined; | ||
| /** Filtered report actions for the transaction thread */ | ||
| reportActions: OnyxTypes.ReportAction[]; | ||
| }; | ||
|
|
||
| const defaultValue: MoneyReportTransactionThreadContextValue = { | ||
| iouTransactionID: undefined, | ||
| requestParentReportAction: null, | ||
| transactionThreadReportID: undefined, | ||
| reportActions: [], | ||
| }; | ||
|
|
||
| const MoneyReportTransactionThreadContext = createContext<MoneyReportTransactionThreadContextValue>(defaultValue); | ||
|
|
||
| type MoneyReportTransactionThreadProviderProps = { | ||
| /** The money request report ID */ | ||
| reportID: string | undefined; | ||
| /** The children */ | ||
| children: ReactNode; | ||
|
TMisiukiewicz marked this conversation as resolved.
Resolved
|
||
| }; | ||
|
|
||
| function MoneyReportTransactionThreadProvider({reportID, children}: MoneyReportTransactionThreadProviderProps) { | ||
|
TMisiukiewicz marked this conversation as resolved.
Resolved
|
||
| const {transactionThreadReportID, transactionThreadReport, reportActions} = useTransactionThreadReport(reportID); | ||
| const [reportActionsForParent] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${getNonEmptyStringOnyxID(reportID)}`); | ||
|
|
||
| // Parent lookup uses the raw Onyx collection so Hold/Unhold still work when the parent IOU is | ||
| // filtered from the report view (e.g. deleted money request) or outside the paginated window. | ||
| const parentReportAction = transactionThreadReport?.parentReportActionID ? reportActionsForParent?.[transactionThreadReport.parentReportActionID] : undefined; | ||
| const requestParentReportAction = isMoneyRequestAction(parentReportAction) ? parentReportAction : null; | ||
|
|
||
| const iouTransactionID = isMoneyRequestAction(requestParentReportAction) ? getOriginalMessage(requestParentReportAction)?.IOUTransactionID : undefined; | ||
|
|
||
| const value: MoneyReportTransactionThreadContextValue = { | ||
| iouTransactionID, | ||
| requestParentReportAction: requestParentReportAction ?? null, | ||
| transactionThreadReportID, | ||
| reportActions: reportActions ?? [], | ||
| }; | ||
|
|
||
| return <MoneyReportTransactionThreadContext.Provider value={value}>{children}</MoneyReportTransactionThreadContext.Provider>; | ||
| } | ||
|
|
||
| function useMoneyReportTransactionThread() { | ||
| return useContext(MoneyReportTransactionThreadContext); | ||
| } | ||
|
|
||
| export default MoneyReportTransactionThreadContext; | ||
| export {MoneyReportTransactionThreadProvider, useMoneyReportTransactionThread}; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.