Repository navigation
Android & iOS - Expense - Description field is not visible when focused - #94398
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2f8c50520
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…or better keyboard event handling
|
@aimane-chnaif You can do final review now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-25.at.10.01.59.AM.movAndroid: mWeb ChromeScreen.Recording.2026-06-25.at.10.04.42.AM.moviOS: HybridAppScreen.Recording.2026-06-25.at.10.00.27.AM.moviOS: mWeb SafariScreen.Recording.2026-06-25.at.10.05.22.AM.movMacOS: Chrome / SafariScreen.Recording.2026-06-25.at.10.05.53.AM.mov |
|
🤖 Review — the approach is sound: footer inputs aren't list items, so 1. The Merchant field has the same problem but isn't fixed. 2. 3. Tests / coverage. The author checklist marks unit tests as added, but I don't see any test files in the diff, and Codecov reports a coverage drop on Minor / non-blocking
This is automated feedback from a code review. A human reviewer should still verify the behavior on device. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🤖 Regression scan — no high-risk regressions found. The risky surface is the change to the shared Why the shared-component changes are safe for existing consumers:
Lower-confidence behavioral edge cases to verify on device (all within the beta flow, not caught by CI): Details
Bottom line: the blast radius is well-contained and the shared-component change is correctly designed to be a no-op for non-beta consumers. The remaining risks are confined to the beta description-field flow and are best verified by device testing rather than code review. This is automated regression analysis. A human reviewer should still verify on-device behavior before merge. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.20-0 🚀
|
|
🤖 No help site changes required. This PR is a mobile-only UI/scroll-behavior bug fix: it ensures the Description field scrolls into view (above the keyboard) when focused during the new manual expense flow on Android & iOS native. It does not change any feature behavior, settings, labels, tabs, or workflows — the change is entirely internal (a The Expensify help site ( @thelullabyy, if you believe any user-facing behavior here is documented on the help site and should be updated, let me know and I'll draft a PR. |
|
We are unable to verify this PR on Native app. BETA is not enabling for Expensifail accounts as well as if we run it on Web and try to use same account on Hybrid. How can we proceed? 1000380169.mp4 |
|
@mvtglobally we can use |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
|
Tested on iOS and it worked as expected for me. |
Explanation of Change
Fixed Issues
$ #94274
PROPOSAL: NA
Tests
Enable
newManualExpenseFlowbetaOffline tests
QA Steps
Enable
newManualExpenseFlowbetaPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-24.at.01.02.03.mov
Android: mWeb Chrome
Screen.Recording.2026-06-24.at.00.57.27.mov
iOS: Native
Screen.Recording.2026-06-24.at.00.37.59.mov
iOS: mWeb Safari
Screen.Recording.2026-06-24.at.00.51.39.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-24.at.00.52.37.mov