Repository navigation
migrate money request part 2 - #95930
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
No product review needed. |
…-request-part-2-v6
…-request-part-2-v6
…-request-part-2-v6
Manual test cases based on current code change & previous PR regression
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariCleanShot.2026-07-18.at.18.35.14.1.mp4CleanShot.2026-07-18.at.18.29.54.1.mp4CleanShot.2026-07-18.at.18.27.15.1.mp4
|
|
@huult We should support sharing routes for both MONEY_REQUEST_STEP_TAX_RATE and MONEY_REQUEST_STEP_TAX_AMOUNT. CleanShot.2026-07-18.at.18.54.24.1.mp4 |
|
@suneox it's done |
…-request-part-2-v6
…-request-part-2-v6
|
Confirmed, the remaining issue has been fixed Share on native platformCleanShot.2026-07-23.at.14.02.01.1.mp4 |
There was a problem hiding this comment.
@huult This PR is missing compatibility configuration for OldRoutes.ts
CleanShot.2026-07-23.at.14.10.20.1.mp4
Suggestion fix
// Money request tax/attendees routes migrated to dynamic routes (PR #95930)
// Old flat path: /<action>/<iouType>/taxRate/<transactionID>/<reportID>
// New dynamic: /r/<reportID>/taxRate?action=...&iouType=...&transactionID=...&reportID=...
'/*/*/taxRate/*/*': '/r/$4/taxRate?action=$1&iouType=$2&transactionID=$3&reportID=$4',
'/*/*/taxAmount/*/*': '/r/$4/taxAmount?action=$1&iouType=$2&transactionID=$3&reportID=$4',
'/*/*/attendees/*/*': '/r/$4/attendees?action=$1&iouType=$2&transactionID=$3&reportID=$4',
|
Thanks! I'll update it once I finish migrating the transaction duplicate flow. I expect it to be done within the next hour. |
…-request-part-2-v6
Screen.Recording.2026-07-23.at.17.59.43.mov@suneox It's done. Could you re-test it? |
…-request-part-2-v6
…-request-part-2-v6
…-request-part-2-v6
…-request-part-2-v6
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.45-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site content under No help site changes are required, so I have not created a draft docs PR. Why: This PR is a purely internal navigation/routing migration for the Tax rate, Tax amount, and Attendee steps of the expense creation flow. It swaps the
Help site articles document user-facing product behavior, and none of that changes here, so there's nothing to update. If I've misjudged the scope — for example if this is expected to alter a documented flow — reply with @huult, please confirm you agree no help site updates are needed here. If you believe a docs change is warranted, let me know what user-facing behavior changed and I'll draft the help site PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |































Explanation of Change
Fixed Issues
$ #83858
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Pre-requisites
MONEY_REQUEST_STEP_TAX_RATE
MONEY_REQUEST_STEP_TAX_AMOUNT
MONEY_REQUEST_ATTENDEE
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-13.at.16.32.38.mov