Repository navigation
fix report rph closes after attendees save - #97190
mjasikowski merged 1 commit into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This comment was marked as outdated.
This comment was marked as outdated.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppCleanShot.2026-07-28.at.16.50.25.2.mp4iOS: mWeb SafariMacOS: Chrome / SafariCleanShot.2026-07-28.at.16.48.01.1.mp4 |
suneox
left a comment
There was a problem hiding this comment.
Confirmed the root cause: the #95930 migration replaced the static backTo param with a transient backPath from useDynamicBackPath. Since
MoneyRequestAttendeeSelector's memo comparator ignores onFinish, the child kept the initial saveAttendees closure holding the not-yet-settled backPath, so
goBack popped past the report and closed the whole RHP. The static backTo never hit this because it was immutable. Using backPathRef.current restores that "read the current value" behavior. Current changeset LGTM.
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…ses-after-attendees-save fix report rph closes after attendees save (cherry picked from commit 3b20ff6) (cherry-picked to staging by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-8 🚀
|
|
🤖 I reviewed the changes in this PR and no help site updates are required. Why: This is an internal navigation bug fix. It changes I checked No draft PR was created since there's nothing to document. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-10 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site changes are required — so I did not create a draft docs PR. Why: This PR is a pure navigation bug fix. It changes It restores the already-expected behavior — it does not add or change any feature, setting, tab, label, or user-facing workflow. The existing help article Adding Attendees already documents the correct flow (open the expense → click Attendees → select → click Save), and it remains accurate after this fix. There is nothing new to document and no wording to correct. @huult, since this is an internal-only bug fix with no user-facing change, there is no linked help site PR to review or mark |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #97165
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.12.41.24.mov