Repository navigation
Conversation
|
@codex review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 210cc0e205
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios1.movios2.moviOS: mWeb SafariMacOS: Chrome / Safariweb1.movweb2.movweb3.mov |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ReviewOverall this looks solid and well-designed. The extraction of the verify-then-resume logic into I verified the one subtle correctness concern and it holds up — see below. A few minor suggestions, none blocking. Correctness check: success vs. abandon race (verified OK)The abandon detection in This is safe because Minor suggestions (non-blocking)
One thing to double-check by design intent: on resume, Nice work — approach and test coverage are good. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.43-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site content under Why: This PR is an internal bug fix / refactor. It introduces the The user-facing product behavior it documents is unchanged — an unvalidated user still has to verify their account before paying. The fix only restores the correct navigation/resume behavior after verification (the regression from #72980). None of that is behavior the help articles describe at a level that would need updating; the payment/verification articles remain accurate as written. Since no changes are required, I did not create a draft help site PR. @jmusial, if you believe a specific article should be updated to reflect this flow, let me know which one and I'll draft the change. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
When an unvalidated user triggers a payment, the new
useVerifyAccountAndResumehook stores the pending payment action, sends the user to the dynamic verify-account (magic code) page, and resumes the stored action once validation succeeds — while dropping it if the user leaves the page without validating.Fixed Issues
$ #72980
PROPOSAL:
Tests
Pre requisite:
Then:
a)
ROUTES.SEARCH_ROOTb)
ROUTES.SEARCH_MONEY_REQUEST_REPORTc)
ROUTES.REPORT_WITH_IDwith the reportIDd) #96091 regression test
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-15.at.11.41.51.mov
Android: mWeb Chrome
Screen.Recording.2026-06-15.at.11.45.47.mov
iOS: Native
Screen.Recording.2026-06-15.at.11.33.22.mov
iOS: mWeb Safari
Screen.Recording.2026-06-15.at.11.25.20.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-11.at.09.55.21.mov
Screen.Recording.2026-07-21.at.13.04.52.mov