Skip to content

[No QA] Remove canUseTrackFlows - #97896

Merged
arosiclair merged 3 commits into
mainfrom
arosiclair-remove-canUseTrackFlows
Aug 5, 2026
Merged

arosiclair merged 3 commits into
mainfrom
arosiclair-remove-canUseTrackFlows

Conversation

@arosiclair

@arosiclair arosiclair commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Removes canUseTrackFlows which should unblock testing of #97521. Based on https://github.com/Expensify/Expensify/issues/504214#issuecomment-4347564829, we can remove this now.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/504214

Tests

Testing in #97521

Offline tests

None

QA Steps

None

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@arosiclair arosiclair self-assigned this Aug 5, 2026
@arosiclair
arosiclair marked this pull request as ready for review August 5, 2026 18:36
@arosiclair
arosiclair requested review from a team as code owners August 5, 2026 18:36
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and mananjadhav and removed request for a team August 5, 2026 18:36
@melvin-bot

melvin-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 5, 2026 18:36
@arosiclair arosiclair changed the title Remove canUseTrackFlows [No QA] Remove canUseTrackFlows Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/Permissions.ts 100.00% <ø> (ø)
...ox/report/actionContents/ChatActionableButtons.tsx 80.43% <100.00%> (ø)
src/pages/DynamicReportDetailsPage.tsx 68.03% <20.00%> (+0.48%) ⬆️
... and 77 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f31639d9b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/DynamicReportDetailsPage.tsx Resolved
@arosiclair
arosiclair merged commit df7808c into main Aug 5, 2026
43 of 44 checks passed
@arosiclair
arosiclair deleted the arosiclair-remove-canUseTrackFlows branch August 5, 2026 19:12
OSBotify pushed a commit that referenced this pull request Aug 5, 2026
…kFlows

[No QA] Remove canUseTrackFlows

(cherry picked from commit df7808c)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 5, 2026
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Aug 5, 2026
52 tasks done
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.50-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — changes required ✅

This PR removes the canUseTrackFlows gate (previously hardcoded off), so the Categorize it and Share it with my accountant options now render as direct buttons in the tracked-expense actionable message in the Expense Chat, alongside Submit it to someone and Nothing for now.

I verified the live behavior on web — tracking a personal expense produced an actionable message with all four options:

Expense Chat actionable message showing all four options

What was out of date: Track-Expenses.md listed Categorize and Share only as "click into the expense" actions and used labels that no longer match the UI (Categorize, Share with your accountant). I updated the "What you can do with tracked expenses" section so the actionable-message options and their labels match the app exactly (Categorize it, Share it with my accountant).

Draft help site PR: #97904


@arosiclair, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

abbasifaizan70 pushed a commit to abbasifaizan70/Expensify that referenced this pull request Aug 5, 2026
…remove-canUseTrackFlows"

This reverts commit df7808c, reversing
changes made to b5e3fbf.
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants