Repository navigation
Conversation
Co-authored-by: Andrew Rosiclair <arosiclair@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://68149ada.helpdot.pages.dev ⚡️ Updated articles: |
|
The only failing check is Check independent approval (the This check isn't a CI/test failure. It's gating on an independent human review: it fails until a reviewer other than the PR author approves the PR. Since this PR was opened by MelvinBot and hasn't been approved yet, the check reports failure by design. Every actual CI check is passing: To clear it: have an independent reviewer approve the PR ( |
Explanation of Change
Help site update for Expensify/App#97896, which removed the
canUseTrackFlowsgate (previously hardcoded off). With that gate gone, the Categorize it and Share it with my accountant options now appear as direct buttons in the tracked-expense actionable message in the Expense Chat, alongside Submit it to someone and Nothing for now.The
Track Expensesarticle previously listed these two options only as "click into the expense" actions and used labels that no longer match the UI (Categorize,Share with your accountant). This PR updates the "What you can do with tracked expenses" section so the actionable-message options and their labels match the current app UI exactly.I verified the live behavior on web: tracking a personal expense produces an actionable message with all four options — Submit it to someone, Categorize it, Share it with my accountant, Nothing for now.
Expense Chat actionable message showing all four options: Submit it to someone, Categorize it, Share it with my accountant, Nothing for now
Fixed Issues
$ #97896
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@arosiclair, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.