Skip to content

Introduce immediate spinner to ButtonCompose - #97956

Closed
OlGierd03 wants to merge 12 commits into
Expensify:mainfrom
software-mansion-labs:@OlGierd03/ButtonCompose-instant-spinner
Closed

OlGierd03 wants to merge 12 commits into
Expensify:mainfrom
software-mansion-labs:@OlGierd03/ButtonCompose-instant-spinner

Conversation

@OlGierd03

@OlGierd03 OlGierd03 commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds an opt-in immediate loading state to ButtonComposed, so a press is acknowledged within a frame instead of after the handler's blocking work. The new shouldShowLoadingImmediatelyOnPress prop wraps the whole onPress: Button commits a local pressed state, lets React paint the spinner, then runs the handler one macrotask later and hands over to the Onyx-driven isLoading (where one exists) with no flicker. Turning it on is a one-line change at the call site.

The engine is the existing usePressLoading, generalized for this: isLoading is now optional (with none passed the pressed state clears once the work settles, instead of waiting for a hand-over that never comes), startWithLoading awaits async handlers and the focus reset subscribes through NavigationContext directly so a Button rendered outside a navigator is fine.

For handlers that validate or branch before doing the work, the prop is the wrong tool (it would spin on a press that does nothing), so those consumers keep calling usePressLoading themselves and pass its isLoading in.

ButtonContext is split into a state context and an actions context (rulesdir/context-provider-split-values), since onPress published to the primitives is now the wrapped handler.

The same mechanism already shipped for form submits in #92498, and the chart below shows why it's worth spreading: daily INP spans for [data-sentry-label="Form-SubmitButton"] fall from 1K to 1.7K to near zero at the 16 Jul deploy, with the badness score flatlining on the same date (the single badness spike on 12 Aug is an unrelated anomaly):

improvement

Fixed Issues

#96058 (see comments: #1, #2)
#96125

Tests

  1. Open an expense report.
  2. Enter the selection mode and select several expenses (the more, the better because the JS thread block on save is easier to observe).
  3. Press Edit multiple in the selection menu.
  4. In the Edit multiple expenses RHP, open any field (e.g. Description), set a new value and press Save on the field page.
  5. Back on the Edit multiple expenses page, press Save.
  6. Verify the spinner appears on Save the instant it is pressed, before the RHP freezes/dismisses, and that it stays visible until the RHP is dismissed (no frame without the spinner).
  7. Verify the edited value is applied to all selected expenses.

Offline tests

QA Steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Before:

before_1.mov

After:

after_1.mov

@codecov

codecov Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...omponents/ButtonComposed/primitives/ButtonIcon.tsx 92.30% <ø> (ø)
...ttonComposed/primitives/ButtonKeyboardShortcut.tsx 100.00% <100.00%> (ø)
...omponents/ButtonComposed/primitives/ButtonText.tsx 100.00% <100.00%> (ø)
src/hooks/usePressLoading.ts 100.00% <100.00%> (+27.27%) ⬆️
...arch/SearchEditMultiple/SearchEditMultiplePage.tsx 0.00% <ø> (ø)
...components/ButtonComposed/context/ButtonContext.ts 85.71% <85.71%> (+10.71%) ⬆️
...ortHeaderPrimaryAction/MarkAsCashPrimaryAction.tsx 0.00% <0.00%> (ø)
src/pages/settings/Wallet/ReportCardLostPage.tsx 0.00% <0.00%> (ø)
src/components/ButtonComposed/Button.tsx 97.82% <90.00%> (-1.02%) ⬇️
... and 271 files with indirect coverage changes

@mikolajpochec mikolajpochec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, but I'd like to address a few nitpicks and a possible code cleanup.

Comment thread src/components/ButtonComposed/types.ts Resolved
Comment thread src/components/ButtonComposed/types.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants